Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] fastify-multipart interceptors #6894

Closed
maronfranc opened this issue Apr 14, 2021 · 1 comment · May be fixed by #6935
Closed

[Feature] fastify-multipart interceptors #6894

maronfranc opened this issue Apr 14, 2021 · 1 comment · May be fixed by #6935
Labels
needs triage This issue has not been looked into type: enhancement 🐺

Comments

@maronfranc
Copy link

Feature Request

Platform Fastify FileInterceptor, FilesInterceptor, AnyFilesInterceptor and FileFieldsInterceptor

Is your feature request related to a problem? Please describe.

There is a fastify-multer pull request and @emagnier asked to consider adding a fastify-multipart version.

Describe the solution you'd like

I implemented a fastify-multipart wrapper that works in a similar way as platform-express interceptors.
I'd like to create a PR, so we can discuss if it is a good solution.

Teachability, Documentation, Adoption, Migration Strategy

The documentation will be almost same as it is, the main difference is that the uploaded file interface is a modified version of fastify-multipart MultipartFile interface.

What is the motivation / use case for changing the behavior?

File upload for platform-fastify.
@maronfranc maronfranc added needs triage This issue has not been looked into type: enhancement 🐺 labels Apr 14, 2021
@kamilmysliwiec
Copy link
Member

Feel free to create a PR for this issue if you have a working version ready 🙌 Just a heads-up however, we cannot promise whether we'll merge it or not just yet (the decision if we want to provide fastify-multipart integration right from the platform-fastify package hasn't been made).

maronfranc added a commit to maronfranc/nest that referenced this issue Apr 20, 2021
@maronfranc
feat(platform): add fastify-multipart support for fastify platform
fae3845 
add FileInterceptor, FilesInterceptor, AnyFilesInterceptor and
FileFieldsInterceptor for platform-fastify

closes nestjs#6894
@maronfranc maronfranc mentioned this issue Apr 20, 2021
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs triage This issue has not been looked into type: enhancement 🐺
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(platform): add fastify-multipart support for fastify platform maronfranc/nest
2 participants
@kamilmysliwiec @maronfranc