Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use shared workspace dependencies image #244

Open
shrugs opened this issue Feb 13, 2025 · 1 comment
Open

use shared workspace dependencies image #244

shrugs opened this issue Feb 13, 2025 · 1 comment

Comments

@shrugs
Copy link
Contributor

shrugs commented Feb 13, 2025

in all of our docker images we keep doing

FROM node:20-slim as base
RUN apt-get update && \
    npm install -g pnpm 
WORKDIR /app

FROM base as deps
COPY pnpm-workspace.yaml ./
COPY package.json pnpm-lock.yaml ./
COPY packages ./packages
COPY apps ./apps

RUN pnpm install --frozen-lockfile

in order to use a package from the monorepo. we might as well abstract this into a ensnode-deps image that we can extend from in each of these dockerfiles

@shrugs shrugs added this to ENSNode Feb 13, 2025
@shrugs shrugs moved this to Todo in ENSNode Feb 13, 2025
@shrugs
Copy link
Contributor Author

shrugs commented Feb 13, 2025

we also probably don't need to apt-get update at all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant