Update German translations, add translation of current state to settings page #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwood77
approved these changes
Feb 23, 2024
Comment on lines
+177
to
+186
| getReadableActivityState(activityState: string): string { | ||
| switch (activityState) { | ||
| case 'Winding': | ||
| return this.translateService.instant('SETTINGS.WINDING'); | ||
| case 'Stopped': | ||
| return this.translateService.instant('SETTINGS.STOPPED'); | ||
| default: | ||
| return this.translateService.instant('SETTINGS.STOPPED'); | ||
| } | ||
| } |
|
Thanks for the contribution and navigating through the front end codebase - it's a bit of a mess, and it's on my list of things to fix 😅 I'll merge your work in and rebuild the front end's filesystem on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks a lot for this great project!
I'm still waiting for some hardware parts, but playing around with the software alone was fun already 🙂
And everything is so well documented, I really like it!
I optimized the German translation and added a translation for the current state to the settings page. I hope this can be added!