Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Add resetPageAfterSortingOrFiltering prop that resets the page after sorting/filtering #16450

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[DataGrid] Add resetPageAfterSortingOrFiltering prop that resets the page after sorting/filtering #16450

wants to merge 2 commits into from

Conversation

arminmeh
Copy link
Contributor

@arminmeh arminmeh commented Feb 4, 2025 •
edited
Loading

Realted to #15378

It is a first PR that will be cherry-picked to v7

#16447 will remove the prop for v8 and include migration notes

Preview
https://deploy-preview-16450--material-ui-x.netlify.app/x/react-data-grid/sorting/#reset-pagination
https://deploy-preview-16450--material-ui-x.netlify.app/x/react-data-grid/filtering/#reset-pagination

Still todo:

  • Documentation update

@arminmeh arminmeh added component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature feature: Sorting Related to the data grid Sorting feature feature: Pagination Related to the data grid Pagination feature enhancement This is not a bug, nor a new feature needs cherry-pick The PR should be cherry-picked to master after merge v7.x feature: Server integration Better integration with backends, e.g. data source labels Feb 4, 2025
@arminmeh arminmeh requested a review from a team February 4, 2025 11:43
arminmeh
arminmeh commented Feb 4, 2025
View reviewed changes
packages/x-data-grid/src/DataGrid/DataGrid.tsx
* This prop will be removed in the next major version and resetting the page will become the default behavior.
* @default false
*/
resetPageAfterSortingOrFiltering: PropTypes.bool,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not happy with the name but couldn't come up with something better
Open for suggestions

@mui-bot
Copy link

mui-bot commented Feb 4, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-16450--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 20ffdf4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature feature: Filtering Related to the data grid Filtering feature feature: Pagination Related to the data grid Pagination feature feature: Server integration Better integration with backends, e.g. data source feature: Sorting Related to the data grid Sorting feature needs cherry-pick The PR should be cherry-picked to master after merge v7.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arminmeh @mui-bot