Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Remove unused classes from gridClasses #16215

Closed
KenanYusuf opened this issue Jan 16, 2025 · 7 comments · Fixed by #16256
Closed

[data grid] Remove unused classes from gridClasses #16215

KenanYusuf opened this issue Jan 16, 2025 · 7 comments · Fixed by #16256
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! customization: css Design CSS customizability v8.x

Comments

@KenanYusuf
Copy link
Member

Whilst working on a fix for #16159, I noticed a few classes that are no longer being used. Using this issue to track the unused classes.

The list needs double checking, but I think we can remove:

  • detailPanels
  • pinnedColumns
  • pinnedRowsRenderZone
@KenanYusuf KenanYusuf added breaking change component: data grid This is the name of the generic UI component, not the React module! v8.x labels Jan 16, 2025
@mateuseap
Copy link
Contributor

Hi @KenanYusuf!
I’m not sure if it’s too early to proceed, but I can check if it’s okay to remove the classes you've listed and open a PR (I can leave it as a draft). Let me know if I can contribute in any way!

@KenanYusuf
Copy link
Member Author

Hey @mateuseap. Sure, feel free to raise a PR!

@mateuseap
Copy link
Contributor

I checked and removed only pinnedRowsRenderZone for now. I haven’t fully looked into the other two classes yet. The PR is open!

@KenanYusuf
Copy link
Member Author

Thanks for opening the PR @mateuseap - it looks good. Do you plan to look at the other two classes?

@mateuseap
Copy link
Contributor

I'll be happy to take a look as soon as I have some time. If you'd like to do it sooner, that's completely fine!

Would you prefer that I add it to my current PR, or should I leave it as is and open a new one? @KenanYusuf

@KenanYusuf
Copy link
Member Author

Awesome - it's ok to add to the current PR since the changes are related.

I will pick it up next week if you don't find time.

@KenanYusuf KenanYusuf added the customization: css Design CSS customizability label Jan 28, 2025
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: data grid This is the name of the generic UI component, not the React module! customization: css Design CSS customizability v8.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants