-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Use re exported utils from packages in docs examples #13901
Conversation
Deploy preview: https://deploy-preview-13901--material-ui-x.netlify.app/ |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
This PR is several month old, is not a draft but has no review requested |
The general direction of the PR makes sense to me, but I wouldn't want to be the reviewer, as I am not fully aware of the scope and usage of these utils in all X products :) |
The logic seems nice to me Do we export from Base UI X packages AND MUI X packages ? Just to avoid doing something we would undo in a few months |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Does the relation still matter if we know that the docs are going to be different and the package will be probably standalone as well? 🤔 |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
@LukasTy is this still something we want to pursue? |
That's up to the team and Olivier to decide. |
From what I understand, most (all?) of those utils will move to the base ui utils package. |
Closing it as it looks like there is no consensus in this regard yet. 🙈 |
This is a follow-up to: #13823 (comment)
<package>/utils
export with utilities, that are used within documentation examplesutils
export and it is also re-exported on root. 🙈@mui/utils
usage from end users