[material-ui][utils] Merge sx instead of override when using mergeSlotProps
#45062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
siriwatknp
commented
Jan 23, 2025
Comment on lines
+49
to
+50
| const typedDefaultSlotProps = defaultSlotProps as Record<string, any>; | ||
| const className = clsx(typedDefaultSlotProps?.className, externalSlotProps?.className); |
There was a problem hiding this comment.
Logic is the same, just types no remove individual type casting below.
siriwatknp
changed the title
sx instead of override when using mergeSlotProps
I think this is a bug fix instead because the current logic does not meet the expected behavior (merging instead of override). |
…merge-slot-props-sx
👍 |
DiegoAndai
approved these changes
Jan 24, 2025
aarongarciah
approved these changes
Jan 24, 2025
|
@siriwatknp if we want this to be available in v6, we need to cherry pick it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #45041
mergeSlotPropscurrently does not merge thesxprop (it will override instead).This PR fix the logic from overriding to merging for
sxprop (similar toclassNameandstyle).I think this is the correct expected behavior.