-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][LinearProgress] Deprecate composed classes #44933
Conversation
…ration instructions
…ormation details" This reverts commit 5617d37.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @headironc!
A couple of this:
- The
MuiLinearProgress-bar1
andMuiLinearProgress-bar2
classes don't exist, we need to add them. When you add them, may I also ask you to add tests to check they're correctly applied? You can use this PR as a guide: https://github.com/mui/material-ui/pull/42281/files - May I also ask you to prepare a sandbox (You can use this one which uses this PR builds) testing that the deprecated classes are correctly replaced by the suggested compositions? For example:
In the sandbox, have two linear progress components, one with:
<LinearProgress
sx={[`&.${linearProgressClasses.bar1Buffer}`]: {
backgroundColor: 'red',
}
/>
and another with:
<Drawer
sx={[`&.${linearProgressClasses.buffer} > .${linearProgressClasses.bar1}`]: {
backgroundColor: 'red',
}
/>
And the result should be the same.
No need to do it with all the combinations, these should be enough:
bar1Buffer
bar1Determinate
bar1Indeterminate
bar2Buffer
barColorPrimary
dashedColorPrimary
packages/mui-codemod/src/deprecations/linear-progress-classes/postcss-plugin.js
Outdated
Show resolved
Hide resolved
@DiegoAndai Okay, I'll finish it. |
…postcss-plugin.js Co-authored-by: Diego Andai <[email protected]> Signed-off-by: headiron <[email protected]>
The sandbox testing that the deprecated classes are correctly replaced by the suggested compositions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job @headironc!
Netlify deploy previewBundle size reportDetails of bundle changes (Toolpad) |
packages/mui-material/src/LinearProgress/linearProgressClasses.ts
Outdated
Show resolved
Hide resolved
packages/mui-material/src/LinearProgress/linearProgressClasses.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Diego Andai <[email protected]> Signed-off-by: headiron <[email protected]>
Co-authored-by: Diego Andai <[email protected]> Signed-off-by: headiron <[email protected]>
Thanks @headironc! |
My pleasure @DiegoAndai! |
part of 41282