Bump Playwright to 1.49.0 #44527

renovate · 2024-11-24T01:43:29Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
@playwright/test (source)	`1.48.2` -> `1.49.0`
playwright (source)	`^1.48.2` -> `^1.49.0`
playwright (source)	`1.48.2` -> `1.49.0`

Release Notes

microsoft/playwright (@playwright/test)

`v1.49.0`

Compare Source

Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

mui-bot · 2024-11-24T01:46:15Z

Netlify deploy preview

https://deploy-preview-44527--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 3f397e6

renovate · 2024-11-25T09:07:58Z

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

aarongarciah · 2024-11-25T13:07:59Z

@mui/code-infra Renovate didn't update the Docker image version in .circleci/config.yml as it did in previous Playwright bumps https://github.com/mui/material-ui/pull/44222/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R383

JCQuintas · 2024-11-25T13:11:46Z

@mui/code-infra Renovate didn't update the Docker image version in .circleci/config.yml as it did in previous Playwright bumps https://github.com/mui/material-ui/pull/44222/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R383

It can't update images because new versions don't use ubuntu focal anymore. Gotta move them to noble

aarongarciah · 2024-11-25T14:09:58Z

After manually pointing Playwright Docker images to playwright:v1.49.0-noble, the test_regression check fails: ReferenceError: __dirname is not defined

https://app.circleci.com/pipelines/github/mui/material-ui/143497/workflows/ca1efb19-79a9-4523-9b6a-9010a8de2c37/jobs/772782

michaldudak · 2024-11-27T10:21:27Z

We had the same issue in Base UI. For some reason, the main test file has to be proper CommonJS or ESM, not a blend of both (which is actually a good thing).

See https://github.com/mui/base-ui/pull/836/files#diff-a00cb0d81882c4a00f2935b720a1e611c08e123551be2103da06c7022cd35ae7

This reverts commit b5e5d38.

aarongarciah · 2024-11-27T11:08:59Z

Thanks @michaldudak. It now works after applying that change.

@mui/code-infra this is ready for review. There's a lot of changed screenshots in Argos (946), most of them probably caused by the Chromium version update (129 -> 131) causing minor differences in text rendering.

JCQuintas · 2024-11-27T11:36:18Z

We had the same issue in Base UI. For some reason, the main test file has to be proper CommonJS or ESM, not a blend of both (which is actually a good thing).

See https://github.com/mui/base-ui/pull/836/files#diff-a00cb0d81882c4a00f2935b720a1e611c08e123551be2103da06c7022cd35ae7

This is odd, we didn't have this issue. mui/mui-x#15493

JCQuintas · 2024-11-27T11:36:34Z

Thanks @michaldudak. It now works after applying that change.

@mui/code-infra this is ready for review. There's a lot of changed screenshots in Argos (946), most of them probably caused by the Chromium version update (129 -> 131) causing minor differences in text rendering.

Our argos changed a lot as well

JCQuintas · 2024-11-27T11:41:34Z

test/regressions/index.test.js

+const path = require('path');
+const fse = require('fs-extra');
+const playwright = require('playwright');


I believe the issue is that you are using @mui/internal-test-utils/setupBabelPlaywright inside test/regressions/.mocharc.js instead of @mui/internal-test-utils/setupBabel

The playwright specific config seems unnecessary to me btw, maybe we should remove it @michaldudak

Changing this to setupBabel causes the tests in Base UI to explode, so it may require a bit more work. I'd love to get rid of webpack and mocha and replace them with vite and vitest at some point.

Ah, but this seems to work in core. I'm still having trouble with vitest on X, but the next step would be to try to use the same tools everywhere indeed.

Is this still a problem?
Are these changes needed?

Yes. I tried removing it and going back to import but it doesn't work.

ZeeshanTamboli · 2025-01-23T07:03:16Z

@mui/code-infra There are many Argos changes. Should we consider this update?

LukasTy · 2025-01-23T07:34:30Z

There are many Argos changes. Should we consider this update?

Those issues look like font aliasing problems that a browser version update could easily cause. 🤔
I don't see a problem bumping this dependency If all issues are the same. 😉

Nitpick: With mui/mui-x#9413 we have refactored the usage of playwright to rely only on the @playwright/test package.

ZeeshanTamboli · 2025-01-23T07:55:48Z

Nitpick: With mui/mui-x#9413 we have refactored the usage of playwright to rely only on the @playwright/test package.

I can do this in a separate PR. Thanks for pointing.

Janpot · 2025-01-23T08:36:52Z

Those issues look like font aliasing problems that a browser version update could easily cause.

It's caused by the ubuntu update

vs.

looks a lot like https://askubuntu.com/questions/1511954/font-rendering-issue-antialiasing

LukasTy · 2025-01-23T08:43:44Z

It's caused by the ubuntu update

Thanks for clarifying. 👍
Regardless, I think we can accept such changes, unless we want to maintain the current behavior and install additional fonts on every CI. 🙈
P.S. We also had the same case on mui/mui-x#15493 (https://app.argos-ci.com/mui/mui-x/builds/27489/122799699).

Janpot · 2025-01-23T08:44:28Z

Yes, we can accept them, I don't think it matters much, we can't control our user's systems neither. My only worry is, how do we know there are no other issues in this update? Ideally we go through all of the changed screenshots to verify the only changes are in font aliasing. It should be fairly quick to do with the red changes overlay and the arrow keys, I've done it before 🙂. (I think we should never accept screenshot changes we haven't verified based on the assumption they are caused by one and the same thing)

LukasTy · 2025-01-23T09:04:37Z

Ideally we go through all of the changed screenshots to verify the only changes are in font aliasing. It should be fairly quick to do with the red changes overlay and the arrow keys, I've done it before 🙂. (I think we should never accept screenshot changes we haven't verified based on the assumption they are caused by one and the same thing)

Oh yes, clearly that has to be done. 🙈
I have done exactly that for mui-x PR and found at least one problem, however, in that case, we had explicit changes in some testing code. 😉

ZeeshanTamboli · 2025-01-23T09:10:39Z

I checked everything but am unsure about these changes:

And several others like these. I don’t see any above changes in the deploy preview of this PR—maybe because I’m using Windows OS.

The rest of the changes show red lines on fonts.

Janpot · 2025-01-23T09:20:59Z

I don’t see any above changes in the deploy preview of this PR

Same, this looks like a bug in argos. Looks like their screenshots don't line up correctly when calculating the diff. Can't find a ticket for it though.

ZeeshanTamboli · 2025-01-23T10:06:57Z

I think we should proceed with accepting the changes.

LukasTy · 2025-01-23T10:08:52Z

I think we should proceed with accepting the changes.

If you have looked through all the diffs and nothing "clearly" wrong jumped to you - go ahead. 👍 🎉

ZeeshanTamboli · 2025-01-23T10:22:59Z

I approved the Argos changes. Can someone review the file changes and approve if they look good?

LukasTy

LGTM, besides the open question about the change of import type.

LukasTy · 2025-01-23T10:33:04Z

test/regressions/index.test.js

+const path = require('path');
+const fse = require('fs-extra');
+const playwright = require('playwright');


Is this still a problem?
Are these changes needed?

Janpot · 2025-01-23T10:35:43Z

Yeah, moving from ESM to commonjs is a regression. I'd prefer it if we either motivate it well or fix it.

This reverts commit 7396614.

ZeeshanTamboli · 2025-01-24T06:42:50Z

Yeah, moving from ESM to commonjs is a regression. I'd prefer it if we either motivate it well or fix it.

So the next step I assume is to keep this PR on hold until we migrate to ESM?

Janpot · 2025-01-24T08:11:07Z

So the next step I assume is to keep this PR on hold until we migrate to ESM?

I would just want to know what's going on. How can, in 2024, an update to a package, force you to regress back to commonjs? Is it a bug in playwright?

ZeeshanTamboli · 2025-01-24T08:41:56Z

So the next step I assume is to keep this PR on hold until we migrate to ESM?

I would just want to know what's going on. How can, in 2024, an update to a package, force you to regress back to commonjs? Is it a bug in playwright?

See conversation from #44527 (comment). Is it because we don't use ESM everywhere?

renovate bot added the dependencies Update of dependencies label Nov 24, 2024

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 25, 2024

aarongarciah force-pushed the renovate/playwright branch from cf21bbf to 126c08c Compare November 25, 2024 09:53

github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Nov 25, 2024

renovate bot force-pushed the renovate/playwright branch from 126c08c to 5c987c5 Compare November 25, 2024 11:07

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 25, 2024

renovate bot force-pushed the renovate/playwright branch from 5c987c5 to dc94959 Compare November 25, 2024 11:35

aarongarciah requested a review from a team November 25, 2024 13:07

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 25, 2024

Bump Playwright to 1.49.0

365c0af

renovate bot force-pushed the renovate/playwright branch from 9eebeb6 to 365c0af Compare November 25, 2024 13:39

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 25, 2024

Point Docker images to noble

6663a33

aarongarciah added 3 commits November 25, 2024 15:10

Merge branch 'master' into renovate/playwright

d7b9105

Merge branch 'master' into renovate/playwright

73e2021

Merge branch 'master' into renovate/playwright

f76e759

aarongarciah added 4 commits November 27, 2024 11:35

Convert regressions test file to CJS

b5e5d38

Merge branch 'master' into renovate/playwright

164fd0a

Revert "Convert regressions test file to CJS"

84e245c

This reverts commit b5e5d38.

Convert regressions test file to CJS

92bdddd

JCQuintas reviewed Nov 27, 2024

View reviewed changes

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 27, 2024

ZeeshanTamboli added 2 commits January 22, 2025 19:49

merge master branch and resolve conflicts

858ba4b

pnpm dedupe

b2b43af

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 22, 2025

ZeeshanTamboli requested review from JCQuintas and michaldudak January 23, 2025 07:03

LukasTy approved these changes Jan 23, 2025

View reviewed changes

ZeeshanTamboli added 3 commits January 24, 2025 11:58

Merge branch 'master' into renovate/playwright

f656fb0

try going back to ESM

7396614

Revert "try going back to ESM"

3f397e6

This reverts commit 7396614.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Playwright to 1.49.0 #44527

Bump Playwright to 1.49.0 #44527

renovate bot commented Nov 24, 2024 •

edited

Loading

mui-bot commented Nov 24, 2024 •

edited

Loading

renovate bot commented Nov 25, 2024

aarongarciah commented Nov 25, 2024

JCQuintas commented Nov 25, 2024

aarongarciah commented Nov 25, 2024

michaldudak commented Nov 27, 2024

aarongarciah commented Nov 27, 2024 •

edited

Loading

JCQuintas commented Nov 27, 2024

JCQuintas commented Nov 27, 2024

JCQuintas Nov 27, 2024

JCQuintas Nov 27, 2024

michaldudak Nov 28, 2024

JCQuintas Nov 28, 2024

LukasTy Jan 23, 2025

ZeeshanTamboli Jan 24, 2025

ZeeshanTamboli commented Jan 23, 2025

LukasTy commented Jan 23, 2025

ZeeshanTamboli commented Jan 23, 2025

Janpot commented Jan 23, 2025

LukasTy commented Jan 23, 2025

Janpot commented Jan 23, 2025 •

edited

Loading

LukasTy commented Jan 23, 2025

ZeeshanTamboli commented Jan 23, 2025

Janpot commented Jan 23, 2025

ZeeshanTamboli commented Jan 23, 2025

LukasTy commented Jan 23, 2025

ZeeshanTamboli commented Jan 23, 2025

LukasTy left a comment

LukasTy Jan 23, 2025

Janpot commented Jan 23, 2025

ZeeshanTamboli commented Jan 24, 2025

Janpot commented Jan 24, 2025

ZeeshanTamboli commented Jan 24, 2025

Bump Playwright to 1.49.0 #44527

Are you sure you want to change the base?

Bump Playwright to 1.49.0 #44527

Conversation

renovate bot commented Nov 24, 2024 • edited Loading

Release Notes

Configuration

mui-bot commented Nov 24, 2024 • edited Loading

Netlify deploy preview

Bundle size report

renovate bot commented Nov 25, 2024

Edited/Blocked Notification

aarongarciah commented Nov 25, 2024

JCQuintas commented Nov 25, 2024

aarongarciah commented Nov 25, 2024

michaldudak commented Nov 27, 2024

aarongarciah commented Nov 27, 2024 • edited Loading

JCQuintas commented Nov 27, 2024

JCQuintas commented Nov 27, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZeeshanTamboli commented Jan 23, 2025

LukasTy commented Jan 23, 2025

ZeeshanTamboli commented Jan 23, 2025

Janpot commented Jan 23, 2025

LukasTy commented Jan 23, 2025

Janpot commented Jan 23, 2025 • edited Loading

LukasTy commented Jan 23, 2025

ZeeshanTamboli commented Jan 23, 2025

Janpot commented Jan 23, 2025

ZeeshanTamboli commented Jan 23, 2025

LukasTy commented Jan 23, 2025

ZeeshanTamboli commented Jan 23, 2025

LukasTy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Janpot commented Jan 23, 2025

ZeeshanTamboli commented Jan 24, 2025

Janpot commented Jan 24, 2025

ZeeshanTamboli commented Jan 24, 2025

renovate bot commented Nov 24, 2024 •

edited

Loading

mui-bot commented Nov 24, 2024 •

edited

Loading

aarongarciah commented Nov 27, 2024 •

edited

Loading

Janpot commented Jan 23, 2025 •

edited

Loading