Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: nextest v0.9.88 requires rustc v1.81 #2365

Open
mxinden opened this issue Jan 16, 2025 · 5 comments · May be fixed by #2366 or #2367
Open

ci: nextest v0.9.88 requires rustc v1.81 #2365

mxinden opened this issue Jan 16, 2025 · 5 comments · May be fixed by #2366 or #2367

Comments

@mxinden
Copy link
Collaborator

mxinden commented Jan 16, 2025

Our rustc v1.76 CI is failing with:

cannot install package cargo-nextest 0.9.88, it requires rustc 1.81 or newer, while the currently active rustc version is 1.76.0

https://github.com/mozilla/neqo/actions/runs/12806683599/job/35705675701?pr=2295

nextest v0.9.88 was released 12h ago:

https://github.com/nextest-rs/nextest/releases/tag/cargo-nextest-0.9.88

I will try to pin nextest.

@sunshowers
Copy link

Hi there -- FYI 0.9.86 bumped the MSRV: https://crates.io/crates/cargo-nextest/versions

Nextest's MSRV policy is "stable minus 2", as documented here: https://nexte.st/docs/stability/#minimum-supported-rust-version-msrv. It looks like a number of projects were relying on the MSRV having been steady across a few versions. In the future, I plan to bump nextest's MSRV more aggressively to ensure that projects aren't relying on a policy which doesn't exist.

(You're always welcome to use the pre-built binaries, of course!)

@sunshowers
Copy link

Ah so the real issue here is that there is likely a Windows race which is preventing quickinstall from installing cargo binstall: https://github.com/mozilla/neqo/actions/runs/12806683599/job/35705675701?pr=2295#step:3:485

You could try using https://nexte.st/docs/installation/pre-built-binaries/#using-nextest-in-github-actions -- this will skip binstall and will fetch the binaries directly from GitHub Releases (what binstall is supposed to do, and successfully did on macOS and Linux).

@larseggert
Copy link
Collaborator

Thanks for the analysis! We'd need to get taiki-e/install-action allowlisted first.

@sunshowers
Copy link

Gotcha! You can also curl the binaries yourself via the URLs at the top of the page, if that makes it easier.

@larseggert
Copy link
Collaborator

@mxinden do you still plan on landing one of the two PRs? (It seems the spurious fail hasn't happened again.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants