Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mozanalysis's DataSource should wrap metric-config-parser's DataSource instead of almost duplicating the functionality #293

Open
danielkberry opened this issue Aug 5, 2024 · 0 comments

Comments

@danielkberry
Copy link
Contributor

As discussed here, mozanalysis's DataSource object contains an almost identical set of parameters as metric-config-parser's DataSource. This leads to the need for converter methods (example) and unnecessary confusion over objects. I propose replacing mozanalysis's DataSource object with something like:

from metric_config_parser import DataSource
from mozanalysis.types import AnalysisUnit

class ExperimentDataSource:
  data_source: DataSource
  app_id: str
  analysis_unit: AnalysisUnit

  def build_query(self, ...) -> str:
     ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant