From 93580f3487c70580b5f03beeb8f5197612344ff1 Mon Sep 17 00:00:00 2001 From: Jonathan Almeida Date: Tue, 7 Apr 2020 17:13:18 -0400 Subject: [PATCH] Close #5913: Remove deprecated WebPushHandler.onSubscriptionChanged API --- .../mozilla/components/concept/engine/webpush/WebPush.kt | 7 ------- components/feature/push/README.md | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/components/concept/engine/src/main/java/mozilla/components/concept/engine/webpush/WebPush.kt b/components/concept/engine/src/main/java/mozilla/components/concept/engine/webpush/WebPush.kt index 392d46ce6e4..40bf243b9c7 100644 --- a/components/concept/engine/src/main/java/mozilla/components/concept/engine/webpush/WebPush.kt +++ b/components/concept/engine/src/main/java/mozilla/components/concept/engine/webpush/WebPush.kt @@ -21,13 +21,6 @@ interface WebPushHandler { */ fun onPushMessage(scope: String, message: ByteArray?) - /** - * Invoked when a subscription has now changed/expired. - * - * This will be deprecated after GeckoView 75; see: https://github.com/mozilla-mobile/android-components/issues/5913 - */ - fun onSubscriptionChanged(subscription: WebPushSubscription) = Unit - /** * Invoked when a subscription has now changed/expired. */ diff --git a/components/feature/push/README.md b/components/feature/push/README.md index a8e8ae1beb3..d6d66c622e3 100644 --- a/components/feature/push/README.md +++ b/components/feature/push/README.md @@ -38,7 +38,7 @@ feature.shutdown() // To receive the subscription info for all the subscription changes. feature.register(object : AutoPushFeature.Observer { - override fun onSubscriptionChanged(subscription: AutoPushSubscription) { + override fun onSubscriptionChanged(scope: PushScope) { // Handle subscription info here. } })