Skip to content
This repository has been archived by the owner on Dec 14, 2021. It is now read-only.

Latest commit

 

History

History
28 lines (17 loc) · 1.1 KB

pull_request_template.md

File metadata and controls

28 lines (17 loc) · 1.1 KB

Fixes #???

(Required: this reference (one or many) will be closed upon merge. Ideally it has the acceptance criteria and designs for features or fixes related to the work in this Pull Request.)

Connected to #???

(Optional: other issues or pull requests related to this, but merging should not close it)

Testing and Review Notes

(Required: steps to take to confirm this works as expected or other guidance for code, UX, and any other reviewers)

Screenshots or Videos

(Optional: to clearly demonstrate the feature or fix to help with testing and reviews)

To Do

  • add “WIP” to the PR title if pushing up but not complete nor ready for review
  • double check the original issue to confirm it is fully satisfied
  • add testing notes and screenshots in PR description to help guide reviewers
  • add unit tests
    • optional: consider adding integration tests (UI specs)
  • consider running this branch in the simulator and check for warnings
  • request the "UX" team perform a design review (if/when applicable)
  • make sure CI builds are passing (e.g.: fix lint and other errors)