Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version increment/deploy path #276

Open
DeviaVir opened this issue May 11, 2017 · 12 comments
Open

Version increment/deploy path #276

DeviaVir opened this issue May 11, 2017 · 12 comments

Comments

@DeviaVir
Copy link
Collaborator

Thinking about, and open for suggestions, a release management that can automatically increment and tag latest version on changes to master.

Needs to update:

  • CHANGELOG.md
  • test/main.js#L65
  • package.json version

Travis? Git hooks?

@abetomo
Copy link
Contributor

abetomo commented May 11, 2017

I think it would be better to use Travis CI.
Would you like me to create a release script?

@abetomo
Copy link
Contributor

abetomo commented May 29, 2017

@DeviaVir What can I do to help?

@DeviaVir
Copy link
Collaborator Author

@abetomo I would like to see how a release script (travis) would look like, any samples you know of?

@abetomo
Copy link
Contributor

abetomo commented May 29, 2017

@DeviaVir I will try to create samples by 6/2 !

@abetomo
Copy link
Contributor

abetomo commented Jun 1, 2017

@DeviaVir
I am not confident of what you expected, but I created a sample.

  1. Add the setting .travis.yml.

  2. Release script created in sample

(The sample script project is a simple one made just to confirm the operation.
It is not exactly the same as node-lambda, but I think that it is okay with almost the same processing.)

@DeviaVir
Copy link
Collaborator Author

DeviaVir commented Jun 1, 2017

@abetomo step 1:
#304
can you review?

@DeviaVir
Copy link
Collaborator Author

DeviaVir commented Jun 1, 2017

still considering step 2, it would be great if travis could take over the entire process of tagging, bumping version and pusing that all to master..

@abetomo
Copy link
Contributor

abetomo commented Jun 1, 2017

@DeviaVir
PR approved.
As you say, it is best to do all with travis.
I will try to see if it is possible.

@abetomo
Copy link
Contributor

abetomo commented Jun 2, 2017

I am checking release processing on travis.
Wait a few more days.

@DeviaVir
Copy link
Collaborator Author

DeviaVir commented Jun 2, 2017

Sure, no rush. Happy with a solution either way.

@abetomo
Copy link
Contributor

abetomo commented Jun 5, 2017

@DeviaVir
There are two ways to push from the travis to the repository.

  • Use token of github
  • Use deploy key

In the case of token, it affects the whole user who created token, but in the case of deploy key, it affects only the registered repository.
Since the impact range is small, we adopted a method using deploy key.

I made a sample up to pushing to master with travis.

  1. Use travis-scripts

  2. Updating travis.yml & release-script.sh

    - stage: Preparation of npm
    node_js: "7"
    script: "./release-script.sh"
    

    Compared to the file in node-lambda now, the above three lines have been added.

  3. How to release

    • Pushing a branch whose branch name begins with release/ will be executed until release.

===
If you write everything here, it will be long, so I will only describe the summary and it will end.
Although it is a brief explanation in release-script.sh(https://github.com/abetomo/node-ss2json/blob/master/release-script.sh), I left a comment.
However, I omitted a detailed explanation.
If you have any questions, please ask a question.

@DeviaVir
Copy link
Collaborator Author

DeviaVir commented Jun 6, 2017

@motdotla looks like I don't have access to set up deploy keys myself, any chance you could follow the steps detailed here (or could you somehow give me access to that part of this repo)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants