[Bug] Job status stay running

[p-paul]

Hello,

First off all: Great Job, the pluging resources is very nice and praticle.

I saw a little trouble with the job status when i use the DemoJob from your example.
The job status never pass to success due to an earler return in you code:

jobs/src/JobManagerProvider.php

Line 108 in cd99146

return;

I update your code in local and it work correclty after:

        if ($failed === false) {
            $attributes += [
                'status' => 'succeeded',
            ];
        } else {
            $attributes += ['status' => 'failed'];
        }

Please let me know if this approach is correct.
See ya :)

[salhdev]

Hi All,

Here is how I fixed the code :

        if ($failed === false) {
            $attributes += [
                'status' => 'succeeded',
            ];
            $monitor->update($attributes);
            return;
        }

[adrolli]

Hey @p-paul and @salhdev,

I was so deep into code that I missed this issue, sorry. Thanks for the issue and the fix! 🎊
I will push out a minor release the next couple of days.

Cheers,
Alf