-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chevrotain CST creation and content security policy. #11
Comments
Thank you for notifying me, I have been focusing on so many other things that I didn't see that the new version was released. If the new version is faster, it might be worth upgrading :) . (I don't have any complaints about the speed, though, I have been very impressed with Chevrotain's speed.) I use a Python script to generate my grammar, and so changes in that area I could accommodate fairly quickly. I'm the one who submitted a PR for the issue so the update probably contains my code :) |
Leaving this issue open until I look what the new version of Chevrotain offers. |
Try integrating with greenkeeper to monitor dependency updates.
There have also been breaking changes to the CST structure/Visitor and even the way tokens have been defined. 😢 If you do meta programming (generating the grammar) you may be interested in the support
Almost, you brought the problem to my attention 👍 , but the solution was to simplify the CST structure and avoid the empty arrays for unmatched [non]Terminals. So the optimizations were no longer needed during CST initialization.
The main upgrade is the CST creation optimization |
Version 3.1 is out now with large lexer performance boost. With the combined performance of multiple optimizations it is even possible you would get X2 the performance by upgrading... |
Hello. 😄
I saw this comment:
The issue with content security policy (new Function)
was resolved in version 3
https://github.com/SAP/chevrotain/blob/master/CHANGELOG.md#300-2-23-2018
But there have been many breaking changes since 0.34 so an upgrade would require a time investment.
The text was updated successfully, but these errors were encountered: