Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputColumn methods could be properties #1688

Closed
ADBond opened this issue Nov 1, 2023 · 1 comment · Fixed by #1730
Closed

InputColumn methods could be properties #1688

ADBond opened this issue Nov 1, 2023 · 1 comment · Fixed by #1730

Comments

@ADBond
Copy link
Contributor

ADBond commented Nov 1, 2023

Lots of InputColumn methods (name, name_l, l_name_as_l, ...) could be properties instead, and I think that would make the usage of the class a little nicer.

Some of them may indeed make more sense to remain as methods, and there may be some reasons why things are as they are.

@RobinL
Copy link
Member

RobinL commented Nov 1, 2023

Yes, I agree. I think it's because when they were first written they had an argument.

I removed the argument, at which point they should have been made properties, but I didn't think of it

87b09c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants