Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enchancement] : Support caddy server #56

Closed
baseplate-admin opened this issue Dec 14, 2022 · 2 comments
Closed

[Enchancement] : Support caddy server #56

baseplate-admin opened this issue Dec 14, 2022 · 2 comments

Comments

@baseplate-admin
Copy link

Hi there,

Thanks for making this awesome project. Do you guys plan to have support for caddyserver?

Here is a simple config to have caddy support X-Sendfile :

   handle /* {
        reverse_proxy localhost:8000 {
            @sendfile header X-Sendfile *
            handle_response @sendfile {
                rewrite {http.reverse_proxy.header.X-Sendfile}
                file_server
            }
        }
    }
@moggers87
Copy link
Owner

If caddy supports X-Sendfile then it should be good to go already.

@baseplate-admin
Copy link
Author

baseplate-admin commented Jan 15, 2023

Caddy by default doesn't have X-Sendfile directive.

From their document they use X-Accel-Redirect

reverse_proxy localhost:8080 {
	@accel header X-Accel-Redirect *
	handle_response @accel {
		root    * /path/to/private/files
		rewrite * {rp.header.X-Accel-Redirect}
		file_server
	}
}

Shouldn't there be a section in documentation clarifying this or how to set up caddyserver?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants