Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using of deprecated function with Django4 #52

Closed
Darbados opened this issue Jan 18, 2022 · 4 comments
Closed

Using of deprecated function with Django4 #52

Darbados opened this issue Jan 18, 2022 · 4 comments

Comments

@Darbados
Copy link

Hellow, the following problem has been faced while migrating to Django 4

from django.utils.http import urlquote
ImportError: cannot import name 'urlquote' from 'django.utils.http'

@ad-m
Copy link

ad-m commented Jan 18, 2022

Could you provide PR to fix that (maybe add Django 4.0 to CI matrix too)?

@Darbados
Copy link
Author

I would like to do it, but I don't see that breaking line of code within the latest main version. I see that you're using the aliases from urllib.parse according to the Django notes, so I guess that the current version is build by an older version of the repo?

@moggers87
Copy link
Owner

Yup, looks like I need to do another release 😸

I'll update the test matrix with Django 4.0 first and then if that goes well I'll do a release.

@moggers87
Copy link
Owner

New release: https://pypi.org/project/django-sendfile2/0.6.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants