Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package #2

Closed
moggers87 opened this issue Mar 20, 2018 · 3 comments · Fixed by #24
Closed

Rename package #2

moggers87 opened this issue Mar 20, 2018 · 3 comments · Fixed by #24

Comments

@moggers87
Copy link
Owner

moggers87 commented Mar 20, 2018

There's another python package using the sendfile package name. We should also take this opportunity to move code out of __init__.py.

  1. Rename package to something like django_sendfile
  2. Move code from __init__.py to sendfile.py
  3. Imports will now look like from django_sendfile import sendfile
@alexandresebrao
Copy link

alexandresebrao commented Jul 21, 2018

I want to know if we could suggest a new name to the package than sendfile. I don't like sendfile at all. django-xsendfile would make more sense to me.

@moggers87
Copy link
Owner Author

@alexandresebrao no, I'm not interested in doing that. This issue is only for renaming the folder where the package is installed to avoid potential conflicts

@bors-ltd
Copy link
Contributor

I must add I found this package because I was desperately looking for a maintained version of django-sendfile. I may have missed it with another name...

Thanks for your work at maintaining this useful little piece of code!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants