Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App router support #3623

Closed
HesamDanaee opened this issue Feb 1, 2024 · 7 comments
Closed

App router support #3623

HesamDanaee opened this issue Feb 1, 2024 · 7 comments

Comments

@HesamDanaee
Copy link

I've switched from page router to the app router but on build time module federation throws error. it's main error is about react-dom which it couldn't find. I was using the 6.4.0 version of module federation and right now it's 8.1.7. did app router support was added in this version? If there is any workarounds please tell me.

@Akshay090
Copy link

App router support is not there currently in the module-federation/nextjs-mf plugin module-federation/core#1183

You can follow this module-federation/core#2002 for more updates

@HesamDanaee
Copy link
Author

Thanks for the response. when would they add support? I'm working on company project which is micro front-end. they asked me to add SSR to the project and I moved from pages router to app router but it just gave me build time errors. I couldn't find the issue because there was no clear error about this problem. would they consider adding app router later?

@ManuelcsNuant
Copy link

Hello, does anyone know the progress on this one or if its going to be supported anytime soon?

@pvsfair
Copy link

pvsfair commented Feb 7, 2024

As @Akshay090 pointed out, people are trying to contribute so this can work, you can follow this module-federation/core#2002 to get some updates.

I think for now they only have had finished the support for the SSR part, and the react is still giving errors.

@ScriptedAlchemy
Copy link
Member

No app router support. If someone sends a PR to support it, otherwise I am not working on the issue as it is low priority.

Maybe in 6 months time ill look at it again.

@marshallcool
Copy link

If someone sends a PR to support it, but Is this not the PR that is needed ?

@ScriptedAlchemy
Copy link
Member

no that does not fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants