From f29b319225ddc9ea89ca534822234395f0c53fad Mon Sep 17 00:00:00 2001
From: Francis Duvivier <francis.duvivier@persgroep.net>
Date: Mon, 3 Feb 2025 22:56:54 +0100
Subject: [PATCH] fix(bridge-react): prevent react-dom/client being bundled
 into dist/index.*.js

this otherwise causes the package to be incompatible with a react 19

BREAKING CHANGE: react-dom/client code will not be bundled into the bridge-react module anymore
---
 .changeset/chilly-zoos-collect.md           | 5 +++++
 packages/bridge/bridge-react/vite.config.ts | 1 +
 2 files changed, 6 insertions(+)
 create mode 100644 .changeset/chilly-zoos-collect.md

diff --git a/.changeset/chilly-zoos-collect.md b/.changeset/chilly-zoos-collect.md
new file mode 100644
index 00000000000..28aa6870bb0
--- /dev/null
+++ b/.changeset/chilly-zoos-collect.md
@@ -0,0 +1,5 @@
+---
+'@module-federation/bridge-react': patch
+---
+
+change rollup config to prevent react-dom/client code being bundled into the bridge-react package
diff --git a/packages/bridge/bridge-react/vite.config.ts b/packages/bridge/bridge-react/vite.config.ts
index 7c647cfa590..e31a03ddb9b 100644
--- a/packages/bridge/bridge-react/vite.config.ts
+++ b/packages/bridge/bridge-react/vite.config.ts
@@ -33,6 +33,7 @@ export default defineConfig({
       external: [
         ...perDepsKeys,
         '@remix-run/router',
+        /react-dom\/.*/,
         'react-router',
         'react-router-dom/',
         'react-router-dom/index.js',