Next 13 app dir

[r34son]

is it planned to add support for next 13 app dir feature?

[ScriptedAlchemy]

When its stable, yes - its a complex problem and quite low on the priority list at the moment.
Theres PR/Issues open around RSC support, but ive been busy with other things that have more immediate impacts to the userbase

[matt-kruse]

Is this something that would be reasonable for anyone else to pick up, @ScriptedAlchemy , or is it complex enough that it's really on you? I really want to see this working. I've dug into it just a little and there's a lot of magic happening behind the scenes. I'll gladly keep digging unless it's a waste of my time. :)

[ScriptedAlchemy]

Yeah anyone could pick it up, id help :)

I mostly know what needs to be done - just dont have the capacity to go through trial and error of it.

If we wanted to support, id suggest we try RSC with the stock webpack example from facebook. Get federation of RSC woring without next, then backport the concept back.

What needs to happen is 1 module needs to become two.

1. normal ssr/client module
2. RSC proxy module

So we need to make a way for exposed modules to export two possibilities, or we need to double expose them and pass one exposed file over the RSC loader

import thing from 'remote/myExposed_RSC' for example, the consumer needs to understand if they are RSC and if so theyd want to load the _RSC name off the entry.

If i had extra hands, im sure we could solve this without much pains. Trial and error takes time though. How next does this is via loader layers. So if the parent import is RSC, it knows the child import should be rsc proxy component.

When you expose stuff though, there is no parent in the same manner - so we need to apply the loader

[matt-kruse]

For me personally, I don't even care about RSC MF. I just want normal CSR run-time MF to work when using /app. I'm looking into the code to try to figure out why it's throwing errors with such a simple use case (one basic remote client component) but I don't know enough about the internals to find my way. I'll keep looking, because I'm interested in understanding and possibly helping.

[snitin315]

@ScriptedAlchemy I think a quick fix would be to add an option that can disable the auto-injection of defaults here:
https://github.com/module-federation/universe/blob/e4b85b537f74a52a48122bf3e9afe6729dc0f6e2/packages/nextjs-mf/src/loaders/patchDefaultSharedLoader.ts#L26-L31

Netx.js 13 expects use client; before any imports in a file, so, in this case, we can import defaults manually.

[ScriptedAlchemy]

@snitin315 if you want to send me a PR, I'm happy to merge into v6

[ScriptedAlchemy]

I'd also recommend looking at the async boundary runtime PR.

With next async, I no longer need auto injection, since shared internals now work

[matsgm]

App Router is now stable since NextJS 13.4 (May 4th, 2023)

[github-actions]

Stale issue message

[matsgm]

Stale issue message

No

[dhalbrook]

I'm seeing this error and I'm not using the app directory at all.

[ScriptedAlchemy]

can you post repo or screenshot?

[dhalbrook]

I realized I commented in the wrong thread. My bad... let me move this discussion.

[ScriptedAlchemy]

#2002