-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make full installation depend on PySide6 by default #12709
Comments
I agree 💯%! Once PySide6 is available and works, qtpy is obsolete because there is no need to support another Qt binding such as PyQt. There are two points in favor of PySide6 that I'd like to highlight more explicity:
|
Okay with switching to a I'd rather not get rid of |
I think people should not be using an old Qt binding, and dropping qtpy would ensure that. I understand if you don't want to do it right now, but we should eventually get rid of it (a year or two seems too long, let's maybe reconsider in half a year or so). |
(on a somewhat related side node I always found it extremely funny that it's the Spyder devs who came up with qtpy, yet not only does Spyder explicitly depend on PyQt5, but even on a very specific version of it -- in addition to qtpy. I find this ironic and it kind of impairs my trust in the approach qtpy has taken -- it seems not even its own devs trust it enough to do the job full and well.) |
-1 from me on dropping qtpy because I would like Qt5 support a bit longer. On our workstations in our department, we don't update our entire anaconda environment that fast and the machines used by our researcher to get their daily work done are still on Qt5 (because Qt6 is not available yet through conda-forge). |
Qt6 is available through conda-forge via PySide6. |
Yes Qt6 has been available on conda-forge for almost 2 years now. Qt6 is more than 3.5 years old. Honest question, if the workstations don't get updated anyway – can you not just stick with an older MNE-Python, then? |
That said I don't feel strongly about qtpy, so for now i'm rather neutral on this one. I just think it's one bit we should definitely consider getting rid of whenever we believe it's convenient! |
wow I feel silly. I always thought pyqt6 would be the official package, but it is pyside6 and that has been available for a long time. I never knew. The solver always refused to install pyside6 because we are also users of Spyder, which depends on pyqt5... This is an informative thread for me. |
Yes Spyder is super odd, they do use qtpy but depend on PyQt5 😵💫 |
FYI I just tried to use PyQt6 and then PySide6 with vscode's Python debugger and ran into microsoft/debugpy#1488 and microsoft/debugpy#1569. So Qt6 support is still in the works / incomplete in |
Looks like @wmvanvliet has been busy trying to make things better there at least :) |
Since the bug with interactive plotting when using PySidd6 has now been fixed, we should be able to replace the PyQt6 dependency in
mne[full]
with PySide6.aarch64
.The abovementioned bug fix should be included in the upcoming release 6.7.3.
Lastly, probably more controversial, but: my opinion is that once we've made the switch, we can (should) drop support for PyQt and get rid of qtpy, which just adds another layer of complexity that
won't be needed anymore: PySide is the official binding, has a more permissive license, and is more actively developed.
The text was updated successfully, but these errors were encountered: