From cef90bd496d0edf5a7d1ddbe27bfd8b047d74fa0 Mon Sep 17 00:00:00 2001
From: Lennart Schneider <lennart.sch@web.de>
Date: Mon, 19 Aug 2024 22:49:26 +0200
Subject: [PATCH] clean up tests, typos

---
 R/SurrogateLearnerCollection.R     | 1 -
 tests/testthat/test_AcqOptimizer.R | 4 ++--
 tests/testthat/test_sugar.R        | 6 +++---
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/R/SurrogateLearnerCollection.R b/R/SurrogateLearnerCollection.R
index 90b2af6c..7ae73662 100644
--- a/R/SurrogateLearnerCollection.R
+++ b/R/SurrogateLearnerCollection.R
@@ -223,7 +223,6 @@ SurrogateLearnerCollection = R6Class("SurrogateLearnerCollection",
 
     # Train learner with new data.
     # Also calculates the insample performance based on the `perf_measures` hyperparameter if `assert_insample_perf = TRUE`.
-    # If
     .update = function() {
       assert_true((length(self$cols_y) == length(self$learner)) || length(self$cols_y) == 1L)  # either as many cols_y as learner or only one
       one_to_multiple = length(self$cols_y) == 1L
diff --git a/tests/testthat/test_AcqOptimizer.R b/tests/testthat/test_AcqOptimizer.R
index ab96d7db..78e82858 100644
--- a/tests/testthat/test_AcqOptimizer.R
+++ b/tests/testthat/test_AcqOptimizer.R
@@ -58,12 +58,12 @@ test_that("AcqOptimizer API works", {
   acqopt$param_set$values$warmstart = TRUE
   xdt = acqopt$optimize()
   expect_true(xdt[["x"]] == 0)
-  expect_true(xdt[[".already_evaluated"]] == FALSE)
+  expect_false(xdt[[".already_evaluated"]])
 
   acqopt$param_set$values$warmstart_size = 1L
   xdt = acqopt$optimize()
   expect_true(xdt[["x"]] == 0)
-  expect_true(xdt[[".already_evaluated"]] == FALSE)
+  expect_false(xdt[[".already_evaluated"]])
 
   acqopt = AcqOptimizer$new(opt("grid_search", resolution = 4L, batch_size = 1L), trm("evals", n_evals = 8L), acq_function = acqfun)
   acqopt$param_set$values$warmstart = TRUE
diff --git a/tests/testthat/test_sugar.R b/tests/testthat/test_sugar.R
index fc101953..0d395e83 100644
--- a/tests/testthat/test_sugar.R
+++ b/tests/testthat/test_sugar.R
@@ -1,13 +1,13 @@
 test_that("SurrogateLearner sugar", {
   surrogate = srlrn(REGR_FEATURELESS, catch_errors = FALSE)
   expect_r6(surrogate, classes = "SurrogateLearner")
-  expect_equal(surrogate$param_set$values$catch_errors, FALSE)
+  expect_false(surrogate$param_set$values$catch_errors)
 })
 
 test_that("SurrogateLearnerCollection sugar", {
   surrogate = srlrn(list(REGR_FEATURELESS, REGR_FEATURELESS$clone(deep = TRUE)), catch_errors = FALSE)
   expect_r6(surrogate, classes = "SurrogateLearnerCollection")
-  expect_equal(surrogate$param_set$values$catch_errors, FALSE)
+  expect_false(surrogate$param_set$values$catch_errors)
 })
 
 test_that("AcqFunction sugar", {
@@ -19,7 +19,7 @@ test_that("AcqFunction sugar", {
 test_that("AcqOptimizer sugar", {
   acqoptimizer = acqo(opt("random_search"), trm("evals"), catch_errors = FALSE)
   expect_r6(acqoptimizer, "AcqOptimizer")
-  expect_equal(acqoptimizer$param_set$values$catch_errors, FALSE)
+  expect_false(acqoptimizer$param_set$values$catch_errors)
 })
 
 test_that("ResultAssigner sugar", {