Skip to content

Commit

Permalink
[c++11] remove boost::shared_array
Browse files Browse the repository at this point in the history
  • Loading branch information
koying committed Feb 10, 2015
1 parent d3c46d2 commit e7fe8f0
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 21 deletions.
8 changes: 4 additions & 4 deletions xbmc/commons/Buffer.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
*/
#include <string.h>
#include <string>
#include <boost/shared_array.hpp>
#include <memory>

namespace XbmcCommons
{
Expand Down Expand Up @@ -88,7 +88,7 @@ namespace XbmcCommons
*/
class Buffer
{
boost::shared_array<unsigned char> bufferRef;
std::shared_ptr<unsigned char> bufferRef;
unsigned char* buffer;
size_t mposition;
size_t mcapacity;
Expand Down Expand Up @@ -132,7 +132,7 @@ namespace XbmcCommons
inline Buffer(size_t bufferSize) : buffer(bufferSize ? new unsigned char[bufferSize] : NULL), mcapacity(bufferSize)
{
clear();
bufferRef.reset(buffer);
bufferRef.reset(buffer, std::default_delete<unsigned char[]>());
}

/**
Expand Down Expand Up @@ -166,7 +166,7 @@ namespace XbmcCommons
inline Buffer& allocate(size_t bufferSize)
{
buffer = bufferSize ? new unsigned char[bufferSize] : NULL;
bufferRef.reset(buffer);
bufferRef.reset(buffer, std::default_delete<unsigned char[]>());
mcapacity = bufferSize;
clear();
return *this;
Expand Down
18 changes: 9 additions & 9 deletions xbmc/threads/test/TestAtomics.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
#include "TestHelpers.h"
#include "threads/Atomics.h"

#include <boost/shared_array.hpp>
#include <memory>
#include <iostream>

#define TESTNUM 100000l
Expand Down Expand Up @@ -85,8 +85,8 @@ class DoSubtract : public IRunnable
TEST(TestMassAtomic, Increment)
{
long lNumber = 0;
boost::shared_array<thread> t;
t.reset(new thread[NUMTHREADS]);
std::shared_ptr<thread> t;
t.reset(new thread[NUMTHREADS], std::default_delete<thread[]>());
DoIncrement di(&lNumber);
for(size_t i=0; i<NUMTHREADS; i++)
t[i] = thread(di);
Expand All @@ -100,8 +100,8 @@ TEST(TestMassAtomic, Increment)
TEST(TestMassAtomic, Decrement)
{
long lNumber = (NUMTHREADS * TESTNUM);
boost::shared_array<thread> t;
t.reset(new thread[NUMTHREADS]);
std::shared_ptr<thread> t;
t.reset(new thread[NUMTHREADS], std::default_delete<thread[]>());
DoDecrement dd(&lNumber);
for(size_t i=0; i<NUMTHREADS; i++)
t[i] = thread(dd);
Expand All @@ -116,8 +116,8 @@ TEST(TestMassAtomic, Add)
{
long lNumber = 0;
long toAdd = 10;
boost::shared_array<thread> t;
t.reset(new thread[NUMTHREADS]);
std::shared_ptr<thread> t;
t.reset(new thread[NUMTHREADS], std::default_delete<thread[]>());
DoAdd da(&lNumber,toAdd);
for(size_t i=0; i<NUMTHREADS; i++)
t[i] = thread(da);
Expand All @@ -132,8 +132,8 @@ TEST(TestMassAtomic, Subtract)
{
long toSubtract = 10;
long lNumber = (NUMTHREADS * TESTNUM) * toSubtract;
boost::shared_array<thread> t;
t.reset(new thread[NUMTHREADS]);
std::shared_ptr<thread> t;
t.reset(new thread[NUMTHREADS], std::default_delete<thread[]>());
DoSubtract ds(&lNumber,toSubtract);
for(size_t i=0; i<NUMTHREADS; i++)
t[i] = thread(ds);
Expand Down
16 changes: 8 additions & 8 deletions xbmc/threads/test/TestEvent.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

#include "threads/test/TestHelpers.h"

#include <boost/shared_array.hpp>
#include <memory>
#include <stdio.h>

using namespace XbmcThreads;
Expand Down Expand Up @@ -571,10 +571,10 @@ class poll_mass_waiter : public IRunnable
}
};

template <class W> void RunMassEventTest(boost::shared_array<W>& m, bool canWaitOnEvent)
template <class W> void RunMassEventTest(std::shared_ptr<W>& m, bool canWaitOnEvent)
{
boost::shared_array<thread> t;
t.reset(new thread[NUMTHREADS]);
std::shared_ptr<thread> t;
t.reset(new thread[NUMTHREADS], std::default_delete<thread[]>());
for(size_t i=0; i<NUMTHREADS; i++)
t[i] = thread(m[i]);

Expand Down Expand Up @@ -610,8 +610,8 @@ TEST(TestMassEvent, General)
{
g_event = new CEvent();

boost::shared_array<mass_waiter> m;
m.reset(new mass_waiter[NUMTHREADS]);
std::shared_ptr<mass_waiter> m;
m.reset(new mass_waiter[NUMTHREADS], std::default_delete<mass_waiter[]>());

RunMassEventTest(m,true);
delete g_event;
Expand All @@ -621,8 +621,8 @@ TEST(TestMassEvent, Polling)
{
g_event = new CEvent(true); // polling needs to avoid the auto-reset

boost::shared_array<poll_mass_waiter> m;
m.reset(new poll_mass_waiter[NUMTHREADS]);
std::shared_ptr<poll_mass_waiter> m;
m.reset(new poll_mass_waiter[NUMTHREADS], std::default_delete<poll_mass_waiter[]>());

RunMassEventTest(m,false);
delete g_event;
Expand Down

0 comments on commit e7fe8f0

Please sign in to comment.