Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading bar dissappears with 0.4.6 [bug] #408

Open
abrahamezzeddine opened this issue Jan 22, 2025 · 5 comments
Open

Loading bar dissappears with 0.4.6 [bug] #408

abrahamezzeddine opened this issue Jan 22, 2025 · 5 comments

Comments

@abrahamezzeddine
Copy link

Hello,

It seems the loading bar dissappears with version 0.4.6. When I downgrade to 0.4.5, it comes back. Any idea why?

Thank you!

@abrahamezzeddine
Copy link
Author

@mkkellogg Hello,

Do you have any idea what the reason could be? I have set showLoadingUI to true, even though it is true by default.

@abrahamezzeddine
Copy link
Author

OK, think I found the bug.

this.rootElement = this.renderer.domElement.parentElement || document.body;
was changed into
this.rootElement = this.renderer.domElement || document.body;

when I reversed this in your code, the loading bar appeared again.

Is there a reason for this change from 0.4.5 --> 0.4.6 (which also affects 0.4.7)? Thanks!

@mkkellogg
Copy link
Owner

Sorry for the late response. I don't think I'm having the same issue, I can see the loading bar just fine on the demo pages (at least on v0.4.7):

Image

What browser and OS are you using?

@abrahamezzeddine
Copy link
Author

abrahamezzeddine commented Feb 12, 2025

Hello,

I am using the npm package (not the demo) and I do not have that kind of bar? I have the circle loading bar, showing the percentage, download, processing splats etc…

Using Chrome / Edge on Windows 11 and both have the same issue.

@mkkellogg
Copy link
Owner

@abrahamezzeddine I think I have a fix in the dev branch, can you see if that works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants