Should will_paginate raise errors when page number is not an integer?

[leods92]

I don't think so.
We usually send a page parameter straight into will_paginate.
Since this seems to be a common practice, I think will_paginate should handle it properly.

In PageNumber#initialize, there's a call to Integer which raises exceptions if value is not parseable. I think we should rescue that.

https://github.com/mislav/will_paginate/blob/master/lib/will_paginate/page_number.rb#L16

Am I missing anything here?

Great job, btw, @mislav 😄
This gem saves lives...

[furiabhavesh]

Yes @leods92, I got this exception today and need this issue to be fixed.

[furiabhavesh]

But why & where does the page number become a non Integer value ? In my case it was "45."

[darrenterhune]

Add constraints to your app: #271

[mislav]

Yep, the exception for invalid page numbers is deliberate. You shouldn't be experiencing errors anyway unless something goes terribly wrong with your pagination links, or a bot hits your site with nonsense query parameters. All of these problems should be remedied in your app under your choosing.