Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider-specific configuration from other eDNS instances breaks this webhook #140

Closed
mircea-pavel-anton opened this issue Dec 14, 2024 · 2 comments · Fixed by #181
Closed
Assignees

Comments

@mircea-pavel-anton
Copy link
Collaborator

If you have multiple external DNS instances, for example this one and cloudflare and you add annotations for both on the same ingress, such as:

---
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
  name: nginx-demo
  namespace: test
  annotations:
    external-dns.alpha.kubernetes.io/hostname: nginx.example.com
    external-dns.alpha.kubernetes.io/cloudflare-proxied: "false"
spec:
  ingressClassName: nginx
  rules:
    - host: nginx.example.com
      http:
        paths:
          - backend:
              service:
                name: nginx
                port:
                  number: 80
            path: /
            pathType: Prefix

Then the mikrotik webhook will complain that cloudflare-proxied is an invalid provider-specific configuration.

This is likely a bug in the upstream external-dns since we should only be getting our webhook annotations and no vendor-specific ones.

@mircea-pavel-anton
Copy link
Collaborator Author

Relevant: kubernetes-sigs/external-dns#4951

@mr-borboto
Copy link
Contributor

mr-borboto bot commented Jan 21, 2025

🎉 This issue has been resolved in version 1.4.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@mircea-pavel-anton mircea-pavel-anton unpinned this issue Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant