We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GetByteStr returns -1 on error, However this return value is ignored wherever the GetByteStr is called.
GetByteStr
This leads to the buffer being uninitialized, which leads to incorrect control flow in the application.
For example, in GetGifWord, the byte buffer will be uninitialized.
GetGifWord
if(--context->restbyte == 0) { context->restbyte = GetByte(i->parent); #if defined(DEBUG) && !defined(NGIFLIB_NO_FILE) if(i->parent->log) fprintf(i->parent->log, "restbyte = %02X\n", context->restbyte); #endif /* defined(DEBUG) && !defined(NGIFLIB_NO_FILE) */ GetByteStr(i->parent, context->byte_buffer, context->restbyte); <- return value ignored context->srcbyte = context->byte_buffer; <- buffer reused }
The text was updated successfully, but these errors were encountered:
miniupnp
No branches or pull requests
GetByteStr
returns -1 on error, However this return value is ignored wherever the GetByteStr is called.This leads to the buffer being uninitialized, which leads to incorrect control flow in the application.
For example, in
GetGifWord
, the byte buffer will be uninitialized.The text was updated successfully, but these errors were encountered: