Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge libpcp into the libnatpmp #24

Open
stokito opened this issue Jan 23, 2022 · 4 comments
Open

Merge libpcp into the libnatpmp #24

stokito opened this issue Jan 23, 2022 · 4 comments

Comments

@stokito
Copy link

stokito commented Jan 23, 2022

When searching for a PCP library most users get to the libpcp which is kind of a reference implementation. The library has IPv6 support. But it's not published in Linux distros and as far I understood is not widelly used. But it still receives some PRs. Having two libraries that do the same thing confuses users.

Is it possible to merge the PCP code from the libpcp into the libnatpmp?
I asked their authors libpcp/pcp#22 but maybe libnatpmp can do that.
Maybe if you are ok but don't have a time to do this then please mark the issue as "help wanted".

@miniupnp
Copy link
Owner

What do you mean by merging ?
why not use libpcp ?

@masterflitzer
Copy link

isn't pcp the successor to nat-pmp? they're not the same thing or am i missing something?

@stokito
Copy link
Author

stokito commented Sep 21, 2023

Yes, the PCP is rework of the NATPMP made by Apple for their routers.
But they don't make new routers so the protocol seems abandoned.
Almost all products that I saw just use the libnatpmp and usually the miniUPNPd is used on a server so the UPNP is used even more often.
I didn't learned it deeply so actually I don't sure even if the PCP has some really big advantages over the NATPMP. Maybe we should just forget it to avoid fragmentation and supporting burden.
I may be wrong because not a specialist in the area.

@masterflitzer
Copy link

natpmp is by apple and pcp was standardized 2013 as successor, idk if i understood your comment correctly but to clarify: pcp should be used and we should forget natpmp to avoid fragmentation

the other way around makes no sense and would be supporting old standards where newer ones are at our fingertips

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants