Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app_installations appears to be broken #122

Closed
anthr76 opened this issue May 9, 2022 · 3 comments · Fixed by #123
Closed

app_installations appears to be broken #122

anthr76 opened this issue May 9, 2022 · 3 comments · Fixed by #123

Comments

@anthr76
Copy link

anthr76 commented May 9, 2022

I'm not entirely sure here why a set would be preferred over a numbered list, but with this usage:

app_installations = [ var.some_number ]

Produces:

The given "for_each" argument value is unsuitable: "for_each" supports maps
and sets of strings, but you have provided a set containing type number.

Error: Invalid for_each set argument

  on .terraform/modules/terraform_github_modules/main.tf line 505, in resource "github_app_installation_repository" "app_installation_repository":
 505:   for_each = var.app_installations
    ├────────────────
    │ var.app_installations is set of number with 1 element
@anthr76
Copy link
Author

anthr76 commented May 9, 2022

Related: #120

@soerenmartius
Copy link
Member

Thanks for reporting this. Yes - actually this should be a set of strings as an installation ID can be eg. 01234. I am gonna provide a fix for this later today.

@soerenmartius soerenmartius mentioned this issue May 10, 2022
Merged
@soerenmartius
Copy link
Member

We just released v0.16.2 which contains the fix for this issue! Again, thanks for bringing this to our attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix type of var.app_installations mineiros-io/terraform-github-repository
2 participants
@soerenmartius @anthr76