Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a MotherDuck Integration #10378

Open
MinuraPunchihewa opened this issue Jan 16, 2025 · 4 comments · May be fixed by #10385
Open

Add a MotherDuck Integration #10378

MinuraPunchihewa opened this issue Jan 16, 2025 · 4 comments · May be fixed by #10385
Labels
enhancement New feature or request

Comments

@MinuraPunchihewa
Copy link
Contributor

MinuraPunchihewa commented Jan 16, 2025

Short description and motivation for the proposed feature

Add a MindsDB integration with MotherDuck.

Resources 💡

🏁 To get started, please refer to the following resources:

Next Steps 🕵️‍♂️ 🕵️‍♀️

  • Familiarize yourself with MotherDuck.
  • Create a new handler that connects MindsDB to MotherDuck.
  • Implement the core features mentioned above.
  • Thoroughly test the integration to ensure proper functionality.
  • Submit a pull request with the new MotherDuck Integration.
@MinuraPunchihewa MinuraPunchihewa added the enhancement New feature or request label Jan 16, 2025
@Nancy9ice
Copy link

Hello @MinuraPunchihewa,

Do it necessarily have to be a new database handler? I think it would be better to just adjust the existing duckdb handler to accommodate connection to Motherduck.

There's no much difference when connecting to duckdb and Motherduck. The major difference is just the Motherduck token that's included in the connection string.

What do you think about this?

@MinuraPunchihewa
Copy link
Contributor Author

Hello @MinuraPunchihewa,

Do it necessarily have to be a new database handler? I think it would be better to just adjust the existing duckdb handler to accommodate connection to Motherduck.

There's no much difference when connecting to duckdb and Motherduck. The major difference is just the Motherduck token that's included in the connection string.

What do you think about this?

Yes, this makes sense. We can also simply extend the DuckDB handler and create a new one for MotherDuck to explicitly support it.
@ZoranPandovski What do you think?

@parthiv11
Copy link
Contributor

@MinuraPunchihewa if this is open i can do it

@MinuraPunchihewa
Copy link
Contributor Author

Hey @parthiv11,
Sure, please go ahead. As Nancy suggested, let's check if incorporate this feature into the existing DuckDB integration. We can also consider extending it and creating a new integration to allow a level of segregation between the two.

@parthiv11 parthiv11 linked a pull request Jan 20, 2025 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants