New version: Stremio.Stremio.Beta version 5.0.0 #207607
Open
+106
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original manifest was from Stremio.Stremio version 5.0.0, but this should have been a incorrect manifest and I removed it from microsoft#207605. :) See microsoft#207120 to know why I do this change.
|
|
|
/AzurePipelines run |
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
|
/AzurePipelines run |
microsoft-github-policy-service
bot
removed
Manifest-Validation-Error
|
Possible duplicate package entry. Similar installer SHA256 hash found in manifest:
|
wingetbot
added
Possible-Duplicate
New-Package
Azure-Pipeline-Passed
|
/AzurePipelines run |
microsoft-github-policy-service
bot
removed
Azure-Pipeline-Passed
wingetbot
added
New-Package
Azure-Pipeline-Passed
stephengillie
requested changes
Jan 6, 2025
microsoft-github-policy-service
bot
added
the
Needs-Author-Feedback
stephengillie
requested changes
Jan 6, 2025
There was a problem hiding this comment.
Hi @DuckDuckStudio,
This package appaers to require VCRedist:
Since the package is x86, I'm guessing that the architecture-specific dependency is needed. There's a chance that the x86 version might need the x64 version of the dependency.
Comment on lines
+21
to
+23
| - Architecture: x86 | ||
| InstallerUrl: https://dl.strem.io/stremio-shell-ng/v5.0.0/StremioSetup-v5.0.0.exe | ||
| InstallerSha256: 46CC52D26EC81113FCE164B1639E3CF0EE83AE86792FFF3A9DFB946D79909106 |
There was a problem hiding this comment.
Suggested change
| - Architecture: x86 | |
| InstallerUrl: https://dl.strem.io/stremio-shell-ng/v5.0.0/StremioSetup-v5.0.0.exe | |
| InstallerSha256: 46CC52D26EC81113FCE164B1639E3CF0EE83AE86792FFF3A9DFB946D79909106 | |
| - Architecture: x86 | |
| InstallerUrl: https://dl.strem.io/stremio-shell-ng/v5.0.0/StremioSetup-v5.0.0.exe | |
| InstallerSha256: 46CC52D26EC81113FCE164B1639E3CF0EE83AE86792FFF3A9DFB946D79909106 | |
| Dependencies: | |
| PackageDependencies: | |
| - PackageIdentifier: Microsoft.VCRedist.2015+.x86 | |
| - Architecture: x64 | |
| InstallerUrl: https://dl.strem.io/stremio-shell-ng/v5.0.0/StremioSetup-v5.0.0.exe | |
| InstallerSha256: 46CC52D26EC81113FCE164B1639E3CF0EE83AE86792FFF3A9DFB946D79909106 | |
| Dependencies: | |
| PackageDependencies: | |
| - PackageIdentifier: Microsoft.VCRedist.2015+.x64 |
There was a problem hiding this comment.
This dependency does not exist in any previous version of this package (but they still passed the review), do I need to add this dependency to any previous version of this package (Stremio.Stremio)?
For example: https://github.com/microsoft/winget-pkgs/pull/205368/files
There was a problem hiding this comment.
Is it possible that the dependency was added at a recent point, and we're only noticing it now?
microsoft-github-policy-service
bot
added
Needs-Attention
Co-authored-by: Stephen Gillie <[email protected]>
auto-merge was automatically disabled
January 6, 2025 23:13
Head branch was pushed to by a user without write access
|
/AzurePipelines run |
microsoft-github-policy-service
bot
removed
Azure-Pipeline-Passed
|
/AzurePipelines run |
wingetbot
added
New-Package
Azure-Pipeline-Passed
stephengillie
added
the
Needs-Author-Feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original manifest was from Stremio.Stremio version 5.0.0, but this should have been a incorrect manifest and I removed it from #207605. :)
See #207120 to know why I do this change.
Check the comments in the manifest to see why the original manifest was a incorrect manifest.
Tip
If the original manifest is indeed wrong, I will have my automation script update the previous manifest.
If my changes are wrong, please also let me know why.
It looks like the earliest PR for this package were not approved by any moderator :(
Microsoft Reviewers: Open in CodeFlow