Terminal skips layout when restoring from tmux

[joaomoreno]

I've had this issue for a while, just never created a ticket for it...

Very often, yet not always, when I reload my workbench, the terminal fails to relayout my tmux setup. I need to resize the terminal using the sash. Hiding and showing the terminal doesn't help. It's as if a layout call is missed somewhere.

[Daniel-McCarthy]

I have peeked at this a bit and started by setting up tmux with two panels as mentioned in the original post. I was able to reproduce this issue as well, however my experience was that when this occurred I was able to consistently make this occur repeatedly by closing the terminal with the X, then going to Terminal > New Terminal, where as reloading allowed it to display properly.

Each time I reproduced this issue successfully I also got this error:

ERR ioctl(2) failed.: Error: ioctl(2) failed. 

at UnixTerminal.resize (/home/user/Documents/vscode/node_modules/node-pty/lib/unixTerminal.js:216:13)

at TerminalProcess.resize (file:///home/user/Documents/vscode/out/vs/workbench/contrib/terminal/node/terminalProcess.js:152:30) 

at TerminalProcessManager.setDimensions (file:///home/user/Documents/vscode/out/vs/workbench/contrib/terminal/browser/terminalProcessManager.js:186:31) 

at _processManager.ptyProcessReady.then (file:///home/user/Documents/vscode/out/vs/workbench/contrib/terminal/browser/terminalInstance.js:1076:86)

In case this helps in finding the issue, I have shared this here as I am not yet sure how to resolve it.

[Tyriar]

Thanks @Daniel-McCarthy, that's helpful and makes sense. Here's the full stack trace from #57976. I'm closing that one off in favor of this.

Issue Id: 2600fd81-4885-05ff-0629-b8f73d22962f

Versions
- 207ace2
- 493869e
- 4e93618
- c827480
- bda8a4d
Stack
Error: ioctl(2) failed.
at UnixTerminal.resize (/node_modules.asar/node-pty/lib/unixTerminal.js:227:13)
/vs/workbench/parts/terminal/node/terminalProcess.ts#123:19 (resize)
/vs/workbench/parts/terminal/electron-browser/terminalProcessManager.ts#158:17 (setDimensions)
/vs/workbench/parts/terminal/electron-browser/terminalInstance.ts#999:72 (onComplete)
/vs/base/common/winjs.base.js#1191:0 (_notify)
/vs/base/common/winjs.base.js#867:0 (enter)
/vs/base/common/winjs.base.js#1089:0 (_run)
/vs/base/common/winjs.base.js#1057:0 (c)
/vs/workbench/parts/terminal/electron-browser/terminalProcessManager.ts#63:4 (call)
/vs/base/common/event.ts#140:15 (fire)
/vs/workbench/parts/terminal/electron-browser/terminalProcessManager.ts#132:24 (call)
/vs/base/common/event.ts#140:15 (fire)
/vs/workbench/parts/terminal/node/terminalProcess.ts#104:25 (_sendProcessId)
/vs/workbench/parts/terminal/node/terminalProcess.ts#69:8

[Tyriar]

Upstream issue: microsoft/node-pty#220

[Tyriar]

The ioctl exception will give more detail on how it failed when #73597 is merged.

[Tyriar]

I looked into this and could repro without the ioctl errors. It really seems like an issue in tmux because the pty is initialized to the correct size, then another resize call is triggered with the same correct size, but tmux still renders wrong. Also strangely telling tmux to relayout fixes it (ctrl+b, r) which indicates to me the issue is in tmux.