Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Robust Markdown Preview #59483

Closed
JaimeStill opened this issue Sep 26, 2018 · 2 comments
Closed

More Robust Markdown Preview #59483

JaimeStill opened this issue Sep 26, 2018 · 2 comments
Assignees
@mjbvz
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality markdown Markdown support issues

Comments

@JaimeStill
Copy link

I like to view the markdown preview as I'm typing to keep track of how it looks. Below are some changes that would be great:

  • Style preview code snippets to match the editor theme (or be overridden if desired).
  • Apply font family to snippets (Fira Code with ligatures). The overall preview font can be set, why not these? I know that you can point to an external style sheet, but I shouldn't have to do this for a common, persistent configuration.
  • Native HTML conversion without the need for an extension. Conversion should keep styling consistent with the preview.

I know this may be a bit nit-picky, but it's really jarring when the editor and preview don't match:

image
@vscodebot
Copy link

vscodebot bot commented Sep 26, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the markdown Markdown support issues label Sep 26, 2018
@mjbvz mjbvz added the feature-request Request for new features or functionality label Sep 28, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Oct 4, 2018

Please split this up into separate feature request issues.

1 and 2 require #56356

3 is a duplicate of #49157

@mjbvz mjbvz closed this as completed Oct 4, 2018
@mjbvz mjbvz added the *duplicate Issue identified as a duplicate of another issue(s) label Oct 4, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality markdown Markdown support issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mjbvz @JaimeStill