Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANSI Escape Sequence (displaying true color) didn't work on Terminal #231628

Closed
ylazy opened this issue Oct 18, 2024 · 9 comments
Closed

ANSI Escape Sequence (displaying true color) didn't work on Terminal #231628

ylazy opened this issue Oct 18, 2024 · 9 comments
Assignees
Labels
info-needed Issue requires more information from poster terminal-conpty Integrated terminal issues related to the ConPTY backend upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues

Comments

@ylazy
Copy link

ylazy commented Oct 18, 2024

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.94.2
  • OS Version: Windows 11 24H2

Steps to Reproduce:

The ANSI Escape sequence didn't work as expected on Terminal panel. RGB Color didn't work, but Bold or Dim are fine. See the screenshot bellow.

The same output, Debug Console displayed correctly:

Image

But Terminal displayed incorrectly:

Image

@ylazy ylazy changed the title ANSI Escape Sequence (coloring) didn't work on Terminal ANSI Escape Sequence (displaying true color) didn't work on Terminal Oct 18, 2024
@ylazy
Copy link
Author

ylazy commented Oct 18, 2024

I tried these settings but the problem still remains:

"terminal.integrated.drawBoldTextInBrightColors": false,
"terminal.integrated.minimumContrastRatio": 1,

@ylazy
Copy link
Author

ylazy commented Oct 18, 2024

simple test:

type hello.txt

download hello.txt

Image

@reaby
Copy link

reaby commented Oct 20, 2024

vscode for WSL2: ansi not working in "DEBUG CONSOLE", but works nicely on terminal:

DEBUG CONSOLE:
Image

TERMINAL:
Image

@DenizUgur
Copy link

I'm experiencing a similar issue; the debug console does not display ANSI escape codes. Running on macOS 15.1 (arm64).

@roblourens
Copy link
Member

Can you share the code?

@roblourens roblourens assigned connor4312 and unassigned roblourens Dec 10, 2024
@connor4312 connor4312 added the info-needed Issue requires more information from poster label Dec 10, 2024
@ylazy
Copy link
Author

ylazy commented Dec 11, 2024

Hi everyone!
This issue is about the Terminal, not the Debug Console.

@roblourens
Copy link
Member

Ah the second set of screenshots threw me off. Can you share the code that produces the output in your original screenshot?

@ylazy
Copy link
Author

ylazy commented Dec 12, 2024

simple test:

type hello.txt
download hello.txt

Image

Ah the second set of screenshots threw me off. Can you share the code that produces the output in your original screenshot?

I've already attached the hello.txt above.
Thank you!

@Tyriar
Copy link
Member

Tyriar commented Dec 19, 2024

This issue seems to originate from an upstream component and is not something VSCode can fix by making a change to our code. As such, I will go ahead and close it. Please try to reproduce in Windows Terminal and report to microsoft/terminal with repro steps.

If you cannot reproduce in Windows Terminal, chances are it's fixed in a later version of Windows. You can read more about how we consume conpty here. Additionally, soon we plan on shipping conpty v2 with VS Code which should bring our behavior in line with Windows Terminal. Thanks for understanding.

/label upstream terminal-conpty windows

@Tyriar Tyriar closed this as completed Dec 19, 2024
@vs-code-engineering vs-code-engineering bot added upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal-conpty Integrated terminal issues related to the ConPTY backend windows VS Code on Windows issues labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster terminal-conpty Integrated terminal issues related to the ConPTY backend upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

7 participants