Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSC 8 terminal hyperlinks don't work properly in Remote - WSL #211443

Open
Tyriar opened this issue Apr 26, 2024 · 4 comments
Open

OSC 8 terminal hyperlinks don't work properly in Remote - WSL #211443

Tyriar opened this issue Apr 26, 2024 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug remote Remote system operations issues terminal-links
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Apr 26, 2024

Repro:

Run printf '\e]8;;file:///home/daniel/dev/Tyriar/xterm.js/README.md\e\\file scheme\e]8;;\e\n' using a file that exists in the workspace. 🐛 Clicking the link does not do anything

image

pwsh repro: write-host "e]8;;file:///home/daniel/dev/Tyriar/xterm.js/README.mde\file schemee]8;;en"`, ⚠ don't verify this on Windows as it's a little broken until conpty v2 (#224488)

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug WSL Issue when using WSL terminal-links labels Apr 26, 2024
@Tyriar Tyriar added this to the Backlog milestone Apr 26, 2024
@Tyriar Tyriar self-assigned this Apr 26, 2024
@BladeMF
Copy link

BladeMF commented Jun 4, 2024

Hi @Tyriar,

Thanks for working on the links! Some questions:

  1. Does this cover links that run in Docker windows (it would appear so)? (The following questions are all in the Docker context and in the integrated terminal)
  2. Does this cover also the vscode protocol?
  3. Wasn't there a vscode-remote protocol? Now it seems to popup the Windows' "Get an app to open vscode-remote". This behaviour seems changed.

@GongT
Copy link

GongT commented Sep 6, 2024

I can confirm it don't work in Remote - SSH.

And it raise "Failed to open: The network name cannot be found. (0x43)" insteadof "Failed to open: The system cannot find the file specified. (0x2)" when use "file://" protocol

@Tyriar Tyriar added remote Remote system operations issues and removed WSL Issue when using WSL labels Dec 18, 2024
@Tyriar
Copy link
Member Author

Tyriar commented Dec 18, 2024

Another report: #204274, possible this is not just remote. I verified it happens on remote - wsl

@Tyriar
Copy link
Member Author

Tyriar commented Dec 20, 2024

Definitely working for me on mac pointing at an existing file. For non-existent files it gives no feedback to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug remote Remote system operations issues terminal-links
Projects
None yet
Development

No branches or pull requests

3 participants