Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color escape sequence cannot be displayed correctly in vscode terminal #206173

Closed
Real-YuZhe opened this issue Feb 24, 2024 · 1 comment
Closed
Assignees
Labels
confirmation-pending terminal-conpty Integrated terminal issues related to the ConPTY backend terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Milestone

Comments

@Real-YuZhe
Copy link

Real-YuZhe commented Feb 24, 2024

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.86.2
  • OS Version: Windows 11 22631.2861

Steps to Reproduce:

  1. Build the sample code and run the sample. It happens when terminal is relatively large, like 245*66 in my case. I build this sample code in WSL2 on kali-linux distribution:
1
  1. Resize terminal size and the image can be displayed correctly:
2
  1. It works well on Windows Terminal:
3
@Tyriar
Copy link
Member

Tyriar commented Dec 10, 2024

This issue seems to originate from an upstream component and is not something VSCode can fix by making a change to our code. As such, I will go ahead and close it. Please try to reproduce in Windows Terminal and report to microsoft/terminal with repro steps.

If you cannot reproduce in Windows Terminal, chances are it's fixed in a later version of Windows. You can read more about how we consume conpty here. Additionally, soon we plan on shipping conpty v2 with VS Code which should bring our behavior in line with Windows Terminal. Thanks for understanding.

/label upstream terminal-conpty windows

@Tyriar Tyriar closed this as completed Dec 10, 2024
@vs-code-engineering vs-code-engineering bot added terminal-conpty Integrated terminal issues related to the ConPTY backend upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues labels Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmation-pending terminal-conpty Integrated terminal issues related to the ConPTY backend terminal-rendering upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

3 participants