Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debounce Terminal Cursor Movement #201710

Closed
hediet opened this issue Jan 3, 2024 · 1 comment
Closed

Debounce Terminal Cursor Movement #201710

hediet opened this issue Jan 3, 2024 · 1 comment
Assignees
Labels
terminal-conpty Integrated terminal issues related to the ConPTY backend upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues

Comments

@hediet
Copy link
Member

hediet commented Jan 3, 2024

The gif doesn't show it, but for me it looked like the cursor jumps with 60hz:

Image

I don't think anyone uses high frequence cursor movements for pwm purposes, so I suggest to debounce rendering a bit when high frequency updates are detected.

@Tyriar
Copy link
Member

Tyriar commented Dec 18, 2024

This is a Windows problem that will be fixed by new conpty stuff 👇. We shouldn't do anything here as we're getting instructions from the pty and executing them as is. We're probably going to have a bad time if we try to change these instructions.

Just debouncing the move will also make the terminal feel laggy in other ways.


This issue seems to originate from an upstream component and is not something VSCode can fix by making a change to our code. As such, I will go ahead and close it. Please try to reproduce in Windows Terminal and report to microsoft/terminal with repro steps.

If you cannot reproduce in Windows Terminal, chances are it's fixed in a later version of Windows. You can read more about how we consume conpty here. Additionally, soon we plan on shipping conpty v2 with VS Code which should bring our behavior in line with Windows Terminal. Thanks for understanding.

/label upstream terminal-conpty windows

@Tyriar Tyriar closed this as completed Dec 18, 2024
@vs-code-engineering vs-code-engineering bot added upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues terminal-conpty Integrated terminal issues related to the ConPTY backend labels Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
terminal-conpty Integrated terminal issues related to the ConPTY backend upstream Issue identified as 'upstream' component related (exists outside of VS Code) windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

2 participants