Terminal implemented ANSI "bold" as "faint colour with bold"

[OzelotVanilla]

Basic Information:

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.76.1
• OS Version: Windows 10 (19045.2604)

Bug Description:

VSCode is implement SGR 1 as fainted colour with bold font, but not purely bold font,
while SGR 2 (faint) is not implemented.

The picture below shows a comparison for VSCode terminal and Windows Terminal PowerShell.
(Left: VSCode, Right: Windows Terminal)

Steps to Reproduce:

1. Write a program that output ANSI sequence effect.

for i in range(1, 3):
    print(f"ANSI \e[{i}m: \033[{i}mText\033[0m")

[OzelotVanilla]

In Ubuntu (WSL), it is correctly implemented:

[Tyriar]

Does changing terminal.integrated.drawBoldTextInBrightColors give you the expected behavior?

[OzelotVanilla]

It seems not working on my computer.
I set the value to false, restart VSCode, and re-run that program, it is still the effect showed before.
I also tried VSCode Insider, not worked there, also.

If it is possible, I want to ask if there is any chance you show me the code which implement these part, or the detailed documentation about that. If possible, I also want to contribute to make the terminal support more ANSI escape sequence.

[Tyriar]

Searching the xterm.js codebase for isBold will show you the usages. For rendering there are 3 renderers which use it:

• Webgl and Canvas (fallback when webgl isn't working): TextureAtlas.ts https://github.com/Tyriar/xterm.js/blob/5b05d4500b30ec5cfa3140d8674f4059741c40f8/src/browser/renderer/shared/TextureAtlas.ts#L529-L532
• DOM (gpu acceleration off): DomRendererRowFactory.ts https://github.com/Tyriar/xterm.js/blob/5b05d4500b30ec5cfa3140d8674f4059741c40f8/src/browser/renderer/dom/DomRendererRowFactory.ts#L284-L286

[vscodenpa]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

[Tyriar]

This is all working as designed AFAIK. We have the terminal.integrated.drawBoldTextInBrightColors setting to tweak the colors to be similar to other terminal emulators. Conpty on Windows could also be causing problems translating sequences which will improve with conpty v2 #224488

/duplicate