From 9289e2be508d232a6865cbe0eb7b666c05187d9a Mon Sep 17 00:00:00 2001 From: Johannes Rieken Date: Tue, 7 Jan 2025 13:54:55 +0100 Subject: [PATCH] chat overlay tweaks (#237395) * don't disable accept/reject when having no changes (it's confusing) * add drop shadow --- src/vs/workbench/contrib/chat/browser/chatEditorActions.ts | 2 +- .../workbench/contrib/chat/browser/media/chatEditorOverlay.css | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/vs/workbench/contrib/chat/browser/chatEditorActions.ts b/src/vs/workbench/contrib/chat/browser/chatEditorActions.ts index a8060733fff3d..731a921c0cad4 100644 --- a/src/vs/workbench/contrib/chat/browser/chatEditorActions.ts +++ b/src/vs/workbench/contrib/chat/browser/chatEditorActions.ts @@ -126,7 +126,7 @@ abstract class AcceptDiscardAction extends Action2 { ? localize2('accept2', 'Accept') : localize2('discard2', 'Discard'), category: CHAT_CATEGORY, - precondition: ContextKeyExpr.and(ctxHasRequestInProgress.negate(), hasUndecidedChatEditingResourceContextKey, ContextKeyExpr.or(ctxHasEditorModification, ctxNotebookHasEditorModification)), + precondition: ContextKeyExpr.and(ctxHasRequestInProgress.negate(), hasUndecidedChatEditingResourceContextKey), icon: accept ? Codicon.check : Codicon.discard, diff --git a/src/vs/workbench/contrib/chat/browser/media/chatEditorOverlay.css b/src/vs/workbench/contrib/chat/browser/media/chatEditorOverlay.css index 26ece80c64cad..a52e4ba5979cc 100644 --- a/src/vs/workbench/contrib/chat/browser/media/chatEditorOverlay.css +++ b/src/vs/workbench/contrib/chat/browser/media/chatEditorOverlay.css @@ -12,6 +12,7 @@ display: flex; align-items: center; z-index: 10; + box-shadow: 0 2px 8px var(--vscode-widget-shadow); } .chat-editor-overlay-widget .chat-editor-overlay-progress {