Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows Terminal]: Screen reader is just announcing a single character information while navigating using ctrl + left/right arrow keys in mark mode. #17892

Open
SaurabhNew opened this issue Sep 10, 2024 · 5 comments · May be fixed by #18106
Labels
A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.

Comments

@SaurabhNew
Copy link

SaurabhNew commented Sep 10, 2024

Windows Terminal version

1.22.2362.0

Windows build number

27695.1000

Other Software

Test Environment:
OS: Windows 11 Version Dev (OS Build 27695.1000)
App: Windows Terminal Preview
Screen Reader: Narrator

Steps to reproduce

Repro steps :
1.Open Windows Terminal.
2.Navigate to the editor.
3.Turn on Narrator by pressing 'Ctrl + Windows + Enter' keys.
4.Now turn on mark mode by pressing 'Ctrl + Shift + M' keys.
5. Now navigate among words using 'Ctrl + Left/Right' keys.
6.Observe the screen reader narration here.

Observation using NVDA and JAWS screen reader:
Same issue repro with NVDA and JAWS screen reader also.

User Experience
Users who rely on screen reader may not get the info properly while navigating in mark mode.

WCAG Reference Link:
https://www.w3.org/WAI/WCAG21/Understanding/info-and-relationships

Attachment :
Screen reader is not announcing full word information while navigating via ctrl + left_right arrow keys.zip

Expected Behavior

Screen reader should narrate complete word information while navigating using ctrl + left/right arrow keys in mark mode.

Actual Behavior

Screen reader is just announcing a single character information while navigating using ctrl + left/right arrow keys in mark mode.
For example:
For word "Microsoft", screen reader is just announcing as 'M selected' when we navigate using 'Ctrl + Left' arrow key and announces as 't selected' using 'Ctrl + Right' arrow.

@SaurabhNew SaurabhNew added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 10, 2024
@Priyanka-Chauhan123 Priyanka-Chauhan123 added Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking A11yWCAG Accessibility tracking HCL-WindowsTerminal Accessibility tracking A11ySev2 Accessibility tracking labels Sep 10, 2024
@carlos-zamora
Copy link
Member

This is by design. Pressing Ctrl+Left/Right moves you to the previous/next word respectively. You're just moving the cursor around, which is why the resulting announcement by the screen reader is what is selected (in the case above, "M"). If you want to expand the selection instead of just moving the cursor, you'll need to hold the Shift key.

Closing as by design.

@carlos-zamora carlos-zamora added the Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. label Sep 10, 2024
@lhecker
Copy link
Member

lhecker commented Sep 10, 2024

But should we perhaps narrate an entire word when the cursor position moves by more than 1 cell? That's what seems to happen when using Word at least. I'm not entirely sure how to implement this though.

@SaurabhNew
Copy link
Author

@carlos-zamora,
This issue is logged from the feedback of Adam Samec. As mentioned in the mail we should be able to navigate among the words using 'Ctrl + Left/Right' arrow keys.
Screen reader is just narrating as selected with single character information instead of narrating the complete word information.

@carlos-zamora
Copy link
Member

I see. Ok, reopening.

Related issues:

I suspect that fixing both of those issues may fix this one inadvertently. Totally based on a hunch, but I wonder if screen readers behave differently when the cursor moves as a degenerate range (like, maybe they automatically read out the current word since there's no selected text).

Tried looking at Word under accevent but all I got was TextSelectionChanged events, which means that the screen reader has special logic to handle that (pretty standard) then calls the UIA APIs off of the text provider.

@carlos-zamora carlos-zamora reopened this Sep 11, 2024
@carlos-zamora carlos-zamora removed the Resolution-By-Design It's supposed to be this way. Sometimes for compatibility reasons. label Sep 11, 2024
@carlos-zamora carlos-zamora added this to the Terminal v1.23 milestone Sep 11, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 11, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Sep 11, 2024
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements labels Sep 11, 2024
@carlos-zamora carlos-zamora linked a pull request Oct 23, 2024 that will close this issue
1 task
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Oct 23, 2024
@Priyanka-Chauhan123
Copy link
Collaborator

@carlos-zamora This bug is impacting Windows Terminal product compliance and making it D. Any expected/tentative ETA by when this issue can be fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11ySev2 Accessibility tracking A11yWCAG Accessibility tracking Area-Accessibility Issues related to accessibility HCL-E+D Accessibility tracking HCL-WindowsTerminal Accessibility tracking In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants