Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.Net: Bug: .NET secret section name is wrong in HomeAutomation Demo. #10049

Open
tanaka-takayoshi opened this issue Jan 1, 2025 · 2 comments
Open

.Net: Bug: .NET secret section name is wrong in HomeAutomation Demo. #10049

tanaka-takayoshi opened this issue Jan 1, 2025 · 2 comments
Labels
bug Something isn't working .NET Issue or Pull requests regarding .NET code

Comments

@tanaka-takayoshi
Copy link
Contributor

Describe the bug
A specified name of the secret section and wrong. The demo project failed to launch.

To Reproduce

  1. Open HomeAutomation project.
  2. Configure secret as written in README.
  3. Execute the project, e.g. dotnet run.
  4. See error

Expected behavior
The project should work fine without error.

Screenshots

Platform

  • OS: confirmed in Windows but not limited.
  • IDE: confirmed in Visual Studio.
  • Language: C#
  • Source: main branch of this repo.

Additional context
This line should be the following:

.Bind(builder.Configuration.GetSection(AzureOpenAIOptions.SectionName))

If it's ok to create one-line pull request, I'll submit.
@tanaka-takayoshi tanaka-takayoshi added the bug Something isn't working label Jan 1, 2025
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code triage labels Jan 1, 2025
@github-actions github-actions bot changed the title Bug: .NET secret section name is wrong in HomeAutomation Demo. .Net: Bug: .NET secret section name is wrong in HomeAutomation Demo. Jan 1, 2025
@evchaki
Copy link
Contributor

evchaki commented Jan 2, 2025

@SergeyMenshykh / @RogerBarreto can you take a look at this?

@evchaki evchaki removed the triage label Jan 2, 2025
@alliscode
Copy link
Member

Hi @tanaka-takayoshi if you would like to contribute a pull request with this fix, we would be happy to take it. Thanks!

@tanaka-takayoshi tanaka-takayoshi mentioned this issue Jan 3, 2025
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Jan 6, 2025
@tanaka-takayoshi @RogerBarreto
.Net: HomeAutomation AzureOpenAI Configuration Fix (#10054)
5b97ad1 
Fixed the secret section name.

### Motivation and Context

<!-- Thank you for your contribution to the semantic-kernel repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->

Fixing #10049

### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

Fix the secret section name to `AzureOpenAI`, described in README.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [X] The code builds clean without any errors or warnings
- [X] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [NA] All unit tests pass, and I have added new tests where possible
- [X] I didn't break anyone 😄

---------

Co-authored-by: Roger Barreto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working .NET Issue or Pull requests regarding .NET code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tanaka-takayoshi @alliscode @evchaki @markwallace-microsoft