Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate overload information on torchlib functions #865

Closed
Tracked by #828 ...
justinchuby opened this issue Jul 12, 2023 · 7 comments
Closed
Tracked by #828 ...

Annotate overload information on torchlib functions #865

justinchuby opened this issue Jul 12, 2023 · 7 comments
Assignees
Labels
module: torchlib Related to the torch/aten function lib in development

Comments

@justinchuby
Copy link
Collaborator

No description provided.

@BowenBao
Copy link
Contributor

BowenBao commented Jul 20, 2023

List of unannotated ops found in diagnostics from onnx bench. @justinchuby @titaiwangms
Update: added a few new ones, removed ones that were missing torchlib op instead of overload.

 'aten.add.Tensor': 35510,
 'aten.bitwise_and.Tensor': 12,
 'aten.clamp.Tensor': 2690,
 'aten.div.Tensor': 10622,
 'aten.div.Tensor_mode': 2,
 'aten.empty.memory_format': 12486,
 'aten.eq.Scalar': 72,
 'aten.eq.Tensor': 112,
 'aten.fill.Tensor': 28,
 'aten.ge.Scalar': 4,
 'aten.ge.Tensor': 4,
 'aten.gt.Scalar': 46,
 'aten.le.Tensor': 32,
 'aten.lt.Scalar': 80,
 'aten.masked_fill.Scalar': 360,
 'aten.masked_fill.Tensor': 396,
 'aten.mul.Tensor': 24214,
 'aten.ne.Scalar': 630,
 'aten.pow.Tensor_Scalar': 528,
 'aten.pow.Tensor_Tensor': 1820,
 'aten.rsub.Scalar': 354,
 'aten.scatter_reduce.two': 18,
 'aten.select.int': 4669,
 'aten.slice.Tensor': 17717,
 'aten.split.Tensor': 3182,
 'aten.sub.Tensor': 7868,
 'aten.sum.dim_IntList': 6122,
 'aten.transpose.int': 13219,
 'aten.unbind.int': 1188,
 'aten.where.self': 732

@BowenBao
Copy link
Contributor

@justinchuby oops I'm also working on this

@justinchuby
Copy link
Collaborator Author

justinchuby commented Jul 25, 2023

aha! do you have a list you are working on? I haven't done anything yet

@BowenBao
Copy link
Contributor

#919

@BowenBao
Copy link
Contributor

There is aten::div.Tensor_Mode left, which should be unsupported, but somehow worked with fallback.

BowenBao added a commit that referenced this issue Jul 25, 2023
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #920
* __->__ #919

Resolves most reported missing overloads from
#865
@BowenBao
Copy link
Contributor

There is aten::div.Tensor_Mode left, which should be unsupported, but somehow worked with fallback.

Tracked by pytorch/pytorch#106057, along with other exporter dispatcher nearest match warnings.

@titaiwangms
Copy link
Contributor

There is aten::div.Tensor_Mode left, which should be unsupported, but somehow worked with fallback.

Fallback seems reasonable, given the current implementation. However, there is one perfect match for this op in th sarif you provided in pytorch/pytorch#106057. That seems like a big bug lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: torchlib Related to the torch/aten function lib in development
Projects
None yet
Development

No branches or pull requests

5 participants