Exit Code and Signal can be undefined

[tsmaeder]

When starting a pty like so:

const terminal = spawn(
            command,
            (isWindows && options.commandLine) || options.args || [],
            options.options || {}
        );

        terminal.onExit(({ exitCode, signal }) => {
            console.log(`terminal:exitCode = ${exitCode}, signal =${signal}`);

and then later doing terminal.kill, I sometimes get terminal:exitCode = undefined, signal =undefined in the log. I belies this should never happen, right?

The problem appears on nodejs 20.18.1 on a windows-2019 github action runner. Locally, it seems to always work.

[tsmaeder]

Updating the runner image to 2022 fixes the problem. I guess the old image is using winPty. Windows build number is 17763, I believe. (https://github.com/actions/runner-images/blob/main/images/windows/Windows2019-Readme.md)

[Tyriar]

17763 is really old. Yes this means you're stuck on winpty which is legacy and we're not touching it anymore. I recommend updating Windows, but you should be able to use useConptyDll in the latest beta builds to get on the newer backend which should be vastly better than winpty (despite being experimental).

node-pty/typings/node-pty.d.ts

Lines 98 to 104 in d32b574

	/**
	* (EXPERIMENTAL)
	*
	* Whether to use the conpty.dll shipped with the node-pty package instead of the one built into
	* Windows. Defaults to false.
	*/
	useConptyDll?: boolean;