Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace.json file should be fully schematized with a JSON schema #6032

Open
garethj-msft opened this issue Jan 16, 2025 · 2 comments
Open
Labels

Comments

@garethj-msft
Copy link
Member

Is your feature request related to a problem? Please describe the problem.

I am trying to build a TypeSpec emitter for the workspace.json file, and to do so accurately, it would be very helpful to have a full JSON schema for the file.

Client library/SDK language

None

Describe the solution you'd like

A json schema file that fully represents the workspace.json file

Additional context

No response

@garethj-msft garethj-msft added status:waiting-for-triage An issue that is yet to be reviewed or assigned type:feature New experience request labels Jan 16, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Jan 16, 2025
@baywet
Copy link
Member

baywet commented Jan 16, 2025

@garethj-msft can you provide more details on why TypeSpec needs to read/write to the workspace file please? (what information)

We've already started a discussion about the auth information in #5073
Beyond that, what else is required?

(and yes, as a general rule of thumb, I'm in favour of a schema, we actually had an initial version here https://github.com/microsoft/kiota/blob/main/specs/schemas/workspace.json but it lacks description, and is probably missing a couple of fields)

@baywet baywet added status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close and removed status:waiting-for-triage An issue that is yet to be reviewed or assigned labels Jan 16, 2025
@garethj-msft
Copy link
Member Author

Hi, sure.

TypeSpec only needs to write to the file, to drive Kiota CLI within TTK. It does not need to read it.
There's information in the file that's duplicated with the TypeSpec file, such as the names of the plugins. This makes it a real pain if you rename your plugin or make another change that needs to be in both files.

By far the simplest dev experience is for TypeSpec to just take over ownership of writing the file in the Copilot DA scenario, as the other, more complex, data such as the Includes/Excludes output of the picker is no longer required (as the user will be modelling just the part of the API they want to use in their plugin in TypeSpec, nothing more)

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Attention 👋 and removed status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Triage 🔍
Development

No branches or pull requests

2 participants