Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

17.6 Text spacing helper flaw #6553

Closed
peterlukerow opened this issue Mar 31, 2023 · 2 comments
Closed

17.6 Text spacing helper flaw #6553

peterlukerow opened this issue Mar 31, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@peterlukerow
Copy link

Description
The styling injected by 17.6 when you enable the text helper is not specific enough and ends up giving a false positive of failure when in fact the site is fine.

In this specific case it is the line height that does not get altered.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.communitydirectory.norfolk.gov.uk/
  2. Enable the extension and/or click the extension button on next to address bar.
  3. Choose Assement option.
  4. Scroll to and expand 17 adaptable content and then click 17.6 Text spacing
  5. Turn on the visual helper

Expected behavior

The letter spacing, word spacing, line height and space after paragraphs should change.

Screenshots

Using extensions
image

If I used a JS bookmarklet from https://codepen.io/stevef/pen/YLMqbo and toggle it on then I get the following as expected:
image

Context (please complete the following information)

  • OS Name & Version: Windows 11 22H2 (Build 22621.1413)
  • AI-Web Version & Environment: v2.373 (official release)
  • Browser Version: MS Edge 113.0.1769.0 (canary 64 bit) and Google Chrome 111.0.5563.147 (Official Build) (64-bit)
  • Target Page: https://www.communitydirectory.norfolk.gov.uk/

Are you willing to submit a PR?

I'm raising this merely because a client is using this tool to verify our work and is raising issues because of it.

Did you search for similar existing issues?

Yes

Additional context

The problem appears to be that the extension is injected styles that are not specific enough to various elements. The example JS bookmarklet applies styles to * and thus appears to have no issues.

@peterlukerow peterlukerow added the bug Something isn't working label Mar 31, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the status: new This issue is new and requires triage by DRI. label Mar 31, 2023
@DaveTryon DaveTryon added status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. and removed status: new This issue is new and requires triage by DRI. labels Apr 4, 2023
@microsoft-github-policy-service
Copy link
Contributor

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@JGibson2019 JGibson2019 removed their assignment Apr 25, 2023
@JGibson2019
Copy link
Contributor

@peterlukerow This is a duplicate of an existing issue in our repo, #4800. We will be closing this issue but you can refer to the other one for updates!

@JGibson2019 JGibson2019 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2023
@JGibson2019 JGibson2019 removed the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants