Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass & Fail - how about adding "Not applicable" to (manual) checks that can not be checked #3228

Closed
BogdanCerovac opened this issue Aug 8, 2020 · 4 comments
Assignees
Labels
feature request resolution: out of scope This issue has been identified as out of scope for this project.

Comments

@BogdanCerovac
Copy link

Is your feature request related to a problem? Please describe.

I think we must think of some checks in terms of trinary logic as we should be able to present the results with "Pass" / "Fail" / "Not applicable". Current solution for the final report now requires some additional manual editing for cases that could be marked as "Not applicable" (or some similar naming suggesting that it is nor pass, nor fail, but not checked).

Describe the desired outcome

For example: I do manual tests on a page that does not include any audio or video elements. Automatic test detect that they are not present and suggest "Not applicable" for all Multimedia checks by default. But I can still manually override it as it may happen that I inject some video dynamically for example, that can potentially not be detected with automatic checking alone.

Describe alternatives you've considered

As described in the desired outcome:

  • test cases for elements not present on the page get "Not applicable" by default, but this can be manually changed by the user.
  • all test cases for all elements that can potentially be "Not applicable" should have a an option to be "Not applicable".
  • all test cases that must be either Pass or Fail should not have an option for "Not applicable" (for example cases that must always be checked - like for example correct language on the document level, alt image text meaning corresponding to image in the context etc.).

Additional context

Possibility to then group end report by "Not applicable" too, and maybe an option to hide all "Non applicable" if it seems reasonable.

@msft-github-bot msft-github-bot added the status: new This issue is new and requires triage by DRI. label Aug 8, 2020
@DaveTryon DaveTryon added status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. and removed status: new This issue is new and requires triage by DRI. labels Aug 8, 2020
@msft-github-bot
Copy link
Collaborator

This issue has been marked as ready for team triage; we will triage it in our weekly review and update the issue. Thank you for contributing to Accessibility Insights!

@DaveTryon DaveTryon removed their assignment Aug 8, 2020
@ferBonnin
Copy link
Contributor

Thanks for your feature request @BogdanCerovac!
This suggestion is something we considered back when we were creating Assessment in Accessibility Insights. To simplify the user workflow and reduce the complexity, we decided to have only 3 states inside Assessment: Pass, Fail and Incomplete; with Pass and Fail the only ones the users need to add.

After reviewing this with the team, we have decided to keep just this 3 states but we understand that there is a need to add comments sometimes so we have feature request #485 open for comments; it will allow users to add a comment to the list of instances; a similar option could be considered for manual requirements in Assessment if that could be helpful.

@ferBonnin ferBonnin added the resolution: out of scope This issue has been identified as out of scope for this project. label Aug 11, 2020
@msft-github-bot
Copy link
Collaborator

This issue has been marked as being beyond the support scope of Accessibility Insights. It will now be closed automatically for house-keeping purposes.

@msft-github-bot msft-github-bot removed the status: ready for triage This issue is ready to be triaged by the Accessibility Insights team. label Aug 11, 2020
@BogdanCerovac
Copy link
Author

Thank you for your explanation. I will check the #485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request resolution: out of scope This issue has been identified as out of scope for this project.
Projects
None yet
Development

No branches or pull requests

4 participants