Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Resizer processes (shrinks) the same image multiple times (for a subset of images) #35114

Open
Nerdoholic opened this issue Sep 28, 2024 · 2 comments
Labels
Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams

Comments

@Nerdoholic
Copy link

Nerdoholic commented Sep 28, 2024

Microsoft PowerToys version

0.84.1

Installation method

PowerToys auto-update

Running as admin

No

Area(s) with issue?

Image Resizer

Steps to reproduce

PowerToysReport_2024-09-28-21-46-57.zip

Prepare a bunch of images. I often work with sets of 50-150, so the issue might only occur on larger batches but not if you resize only 10 images at once.

I could not link the behaviour to anything. Same source (mobile phone), same resolution, no specific order e.g. by filename that would link to stuff like "every nth process".

I do overwrite in place.

Env: W11, 7950X3D, PCIe4 SSD (adding in case it's performance related).

✔️ Expected Behavior

Images are only processed once.

❌ Actual Behavior

Some (seemingly random) images are processed multiple times.

[edit1]
As in
Source 3472x4624px (WxH)
becomes 1080x1438px (WxH)
becomes 640x852px (WxH)

Wait a minute... was just editing to add this detail and calc the ratio (e.g. ratio applied double?).
Isn't 852 one of the default values for Small...?
https://learn.microsoft.com/en-us/windows/powertoys/image-resizer#settings
Ok it's 854x480. So not only different (yet close!) but also the wrong value (width instead of height).

I use "Medium" 1920x1080 in any case :)
[/edit 1]

[edit 2]
Just noticed something else. Width and Height are flipped anyway!?
image

Then 852/854 is suddenly becoming very interesting again, no? :)
[/edit2]

image

image

image

2024-09-28 21_43_55

Other Software

No response

@Nerdoholic Nerdoholic added Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Sep 28, 2024
@Nerdoholic Nerdoholic changed the title Image Resizer runs multiple times for only a subset of images Image Resizer runs multiple times (shrinks double!) for only a subset of images Sep 28, 2024
@Nerdoholic
Copy link
Author

Nerdoholic commented Dec 21, 2024

Issue still present in 0.87.1.

I created a folder with ~1.000 JPEGs and PNGs for testing, and ran 10 of these folders in parallel.


JPEG:
Good mix of low, mid and high error rates.

Run 1 2 3 4 5 6 7 8 9
Errors 6 2 5 9 3 3 7 8 6

Image

Image

Image

Image

Image


PNG:
Occurs quite a bit less often.

Run 1 2 3 4 5 6 7 8 9
Errors 1 3 2 1 0 2 0 2 2

Image


I then ran the test for JPEG again, this time with the "Overwrite" option set to "Off".

Image

This noticeably increased the error rate.

Run 1 2 3 4 5 6 7 8 9
Errors 13 12 8 9 12 12 13 10 16

Image


Conclusion: There is probably a dependency to the computing speed.
As expected, I can tell just by feel that PNG was by far the slowest. JPEG with Overwrite enabled was pretty fast. JPEG with Overwrite disabled didn't even give me a chance to run a parallel session, because the operation would already be done by that point (we are talking <3 sec here to start each following session).

I'm running this on a 16C/32T 7950X3D + 64GB DDR5-5400 + PCIe-5.0x4 990 Evo 1TB.


Taking this into funland: Same system but this time we're using a years-old 4TB HDD via USB 2.0 dock....

We are of course heavily IO throttled, so I'm running 3 at a time max...

Image

Image

Run 1 2 3 4 5 6 7 8 9
Errors 4 4 8 6 8 9 6 9 4

Given this was always 10+ on an SSD, the IO throttling noticeably improves the error rate.

@Nerdoholic Nerdoholic changed the title Image Resizer runs multiple times (shrinks double!) for only a subset of images Image Resizer processes (shrinks) multiple times on fast machines (for a subset of images) Jan 3, 2025
@Nerdoholic Nerdoholic changed the title Image Resizer processes (shrinks) multiple times on fast machines (for a subset of images) Image Resizer processes (shrinks) the same image multiple times on fast machines (for a subset of images) Jan 3, 2025
@Nerdoholic Nerdoholic changed the title Image Resizer processes (shrinks) the same image multiple times on fast machines (for a subset of images) Image Resizer processes (shrinks) the same image multiple times (for a subset of images) Jan 3, 2025
@Nerdoholic
Copy link
Author

Classic Microsoft.

Invest $300b in AI crap nobody wants, invest another $100b in forcing that AI crap onto users.

But invest into resources for actual feature development like PT? Yeah.

Throw $5b onto this and the next Windows version would be an amazing futuristic civilization thingy, instead all I see in the bug section is https://giphy.com/gifs/tumbleweed-1Zbeweu52ZaQE
September dude. Fucking September -_-

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug Something isn't working Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams
Projects
None yet
Development

No branches or pull requests

1 participant